Skip to content

[Feat] 모의 서류 지원 홈 목록 API 추가#69

Merged
whc9999 merged 1 commit into
mainfrom
feat/#38-mock-apply-home
May 22, 2026
Merged

[Feat] 모의 서류 지원 홈 목록 API 추가#69
whc9999 merged 1 commit into
mainfrom
feat/#38-mock-apply-home

Conversation

@whc9999
Copy link
Copy Markdown
Collaborator

@whc9999 whc9999 commented May 22, 2026

✨ 어떤 이유로 PR를 하셨나요?

  • feature 병합
  • 버그 수정(아래에 issue #를 남겨주세요)
  • 코드 개선
  • 코드 수정
  • 배포
  • 기타(아래에 자세한 내용 기입해주세요)

📋 세부 내용 - 왜 해당 PR이 필요한지 작업 내용을 자세하게 설명해주세요

  • 내 모의 서류 지원 목록 조회 API 추가
  • 이어쓰기/완료 결과 카드 응답 분리
  • 공고, 회사, 직무, 상태, 점수, 이어가기 경로 정보 포함
  • 홈 목록 조회 테스트 추가

📸 작업 화면 스크린샷

⚠️ PR하기 전에 확인해주세요

  • 로컬테스트를 진행하셨나요?
  • 머지할 브랜치를 확인하셨나요?
  • 관련 label을 선택하셨나요?

🚨 관련 이슈 번호 [#38]

Summary by CodeRabbit

  • New Features

    • Added an authenticated endpoint (GET /api/mock-applies/me) allowing users to retrieve their mock applications, automatically organized into "in progress" and "completed" categories with associated job posting and company details.
  • Tests

    • Added comprehensive test coverage validating that mock applications are correctly retrieved and organized by completion status, with proper data validation across all fields.

Review Change Stack

- 내 모의 서류 지원 목록 조회 API 추가
- 이어쓰기/완료 결과 카드 응답 분리
- 공고, 회사, 직무, 상태, 점수, 이어가기 경로 정보 포함
- 홈 목록 조회 테스트 추가
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 22, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: d3a7537a-6783-470d-b779-4d9e19cdadd3

📥 Commits

Reviewing files that changed from the base of the PR and between 421a0b8 and 5f92ce8.

📒 Files selected for processing (6)
  • src/main/java/com/jobdri/jobdri_api/domain/mockapply/controller/MockApplyController.java
  • src/main/java/com/jobdri/jobdri_api/domain/mockapply/dto/response/MockApplyHomeItemResponse.java
  • src/main/java/com/jobdri/jobdri_api/domain/mockapply/dto/response/MockApplyHomeResponse.java
  • src/main/java/com/jobdri/jobdri_api/domain/mockapply/repository/MockApplyRepository.java
  • src/main/java/com/jobdri/jobdri_api/domain/mockapply/service/MockApplyService.java
  • src/test/java/com/jobdri/jobdri_api/domain/mockapply/service/MockApplyServiceTest.java

📝 Walkthrough

Walkthrough

This PR adds a new authenticated GET /api/mock-applies/me endpoint that returns the current user's mock applications organized into in-progress and completed lists. The implementation spans response DTOs, an optimized repository query with eager loading, service orchestration that filters by completion status, a controller endpoint, and comprehensive integration tests.

Changes

Mock Applies Home Screen

Layer / File(s) Summary
Response DTOs and data contracts
src/main/java/com/jobdri/jobdri_api/domain/mockapply/dto/response/MockApplyHomeItemResponse.java, src/main/java/com/jobdri/jobdri_api/domain/mockapply/dto/response/MockApplyHomeResponse.java
MockApplyHomeItemResponse record holds individual apply metadata (ID, resume path, job/company details, status, timestamps, apply type, score) with from(MockApply) factory and resumePath() helper that maps status to URL routes; MockApplyHomeResponse aggregates in-progress and completed item lists.
Repository query with eager loading
src/main/java/com/jobdri/jobdri_api/domain/mockapply/repository/MockApplyRepository.java
findHomeItemsByUserId() query fetch-joins jobPosting, company, detailClassification, and analysis entities to prevent N+1 queries; results ordered by createdAt and id descending.
Service orchestration and filtering
src/main/java/com/jobdri/jobdri_api/domain/mockapply/service/MockApplyService.java
getMyMockApplies(User) validates user, loads home items from repository, maps to response DTOs, and partitions results by completion status using filterByCompletion() helper to separate COMPLETED from in-progress applies.
HTTP endpoint
src/main/java/com/jobdri/jobdri_api/domain/mockapply/controller/MockApplyController.java
GET /me endpoint extracts authenticated user and delegates to service, returning ApiResponse<MockApplyHomeResponse>.
Service integration test
src/test/java/com/jobdri/jobdri_api/domain/mockapply/service/MockApplyServiceTest.java
getMyMockApplies() test persists in-progress and completed applies for target user plus an extra apply for a different user, creates and persists an Analysis for the completed item, invokes the service, and validates list separation, required fields (company, classification, job title, apply type, score), and computed resume paths.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Suggested labels

✨ feat

Poem

🐰 A rabbit hops through data flows so clean,
Applies sorted by their state—seen and unseen,
With eager joins and partitions done right,
The home screen endpoint shines oh-so-bright!
From repository to response, each layer in place,
A feature complete with test-proven grace.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title '[Feat] 모의 서류 지원 홈 목록 API 추가' accurately describes the main change: adding a new mock application home list API endpoint.
Description check ✅ Passed The PR description follows the repository template with all required sections completed: feature type checked, detailed work description provided, local testing confirmed, branch verification checked, and related issue #38 referenced.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/#38-mock-apply-home

Comment @coderabbitai help to get the list of available commands and usage tips.

@whc9999 whc9999 merged commit a30b030 into main May 22, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant