Add Swift UIKit utils cinterop support for iOS#3233
Conversation
fa91e66 to
c07ec30
Compare
There was a problem hiding this comment.
IMO we can rename this target to CMPUIKitObjcUtils
There was a problem hiding this comment.
Let's rename it right away!
There was a problem hiding this comment.
TBH, I would love to see at least one simple swift class + simple Kotlin test to ensure the interop works.
There was a problem hiding this comment.
test added to iosTest
|
Vendula Švastalová (@svastven) , could you please also verify (or confirm that you did it) that compose is still compiles and can be used is CMP project. To verify so, you need:
|
|
Andrei Salavei (@ASalavei) I have confirmed that using Swift class from |
Yes please check that. Need to ensure that all required compiler/linker flags correctly propagated to the final user's projects. Would be great to test that project with |
I published a dev Maven build with temporary test logging added in val box = CMPUIKitSwiftInteropBox(seed = 7)
val interop: CMPUIKitSwiftInteropProtocol = box
println("CMPUIKitSwiftInterop: ${interop.seed()}, ${box.seed()}")
println("CMPUIKitSwiftInterop: ${interop.combinedValueWithSuffix("swift")}, ${box.combinedValueWithSuffix("kotlin")}"), which uses types from |
The build changes LGTM. If you don't need from me to look at the rest of the code, it is good to merge |
Adds a separate
CMPUIKitSwiftUtilsstatic library alongside the existing Objective-CCMPUIKitUtilslibrary, so Swift-only iOS APIs can be exposed to Kotlin/Native through an Objective-C-compatible generated Swift header.Fixes CMP-10497 [iOS] Add Swift UIKit utils cinterop support
Release Notes
N/A