chore(ci): relax codecov patch check to 85% floor + informational#634
Merged
JasonXuDeveloper merged 1 commit intomasterfrom Apr 23, 2026
Merged
chore(ci): relax codecov patch check to 85% floor + informational#634JasonXuDeveloper merged 1 commit intomasterfrom
JasonXuDeveloper merged 1 commit intomasterfrom
Conversation
Codecov was set to target: auto with a 1% threshold on both project and patch, so every PR had to stay within 1% of the current ~95% project coverage. That ratchets tighter each time new easily-tested code is added, and penalises PRs that touch editor-window callbacks or polling loops which are not cleanly unit-testable. Switch to a fixed 85% floor with 2% threshold on both checks, and mark the patch check informational so the Codecov comment still surfaces dropped lines (useful for review) but does not block merge. The project check still guards against real regressions. Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com> Signed-off-by: JasonXuDeveloper - 傑 <jason@xgamedev.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The previous codecov config used `target: auto` with a 1% threshold on both `project` and `patch`. That ratchets the bar tighter each time new easily-tested code lands, and penalises PRs that touch editor-window callbacks or polling loops which are not cleanly unit-testable (e.g. `Panel.OnFocus`, `schedule.Execute` polling).
Discovered on #633 — 95.81% patch coverage was flagged as ❌ because it was below the ~95% base.
Changes
Test plan