Fixed various issues#61
Merged
Merged
Conversation
coot
force-pushed
the
coot/dmq-issues
branch
3 times, most recently
from
c05671a to
8c91244
Compare
crocodile-dentist
approved these changes
Jun 23, 2026
crocodile-dentist
left a comment
crocodile-dentist
left a comment
Contributor
There was a problem hiding this comment.
lgtm, minor comments
crocodile-dentist
approved these changes
Jun 23, 2026
Since we use `State s (Except e)` monad when validating a signature, we can update the state at any point. If a signature will be invalid in by a subsequent validation check the updated state will be thrown away. PoolId can be computed once.
Each `PoolId` can emit one signature every `60` seconds.
Generate more transactions, this improves discovering a peer metric counter examples by ~10x. Use `shrinkMapBy` and `shrinkList` to implement a `Map` shrinker. This way we also shrink keys and values in the map. The original shrinker also had a bug which resulted in an infinite loop.
Instead of reporting each sig id separately we report all received sig ids at once. The main difference is that now the peer metric will remove old entries regardless whether we received an empty list of not. The pure model of peer metric was updated. This was triggered by a counterexample found where the model inadequately removed old entries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
List of changes
Checklist