chore: mark date-time input and mask input components as indirect render#2249
Merged
Conversation
rkaraivanov
previously approved these changes
Jun 10, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds Blazor analyzer metadata markers to several components/base classes so that the Blazor integration can treat date-time/mask/input-related components (and supporting mixins/APIs) as using indirect rendering and/or supporting visual children.
Changes:
- Add
/* blazorIndirectRender */and/* blazorSupportsVisualChildren */markers to input/date-time-input/mask-input component entry points and base classes. - Add Blazor analyzer suppression markers for specific APIs (e.g.
expandToItem) and event-related members. - Mark combo-box mixin base classes with
/* omitModule */for Blazor tooling.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/components/tree/tree.ts | Adds /* blazorSuppress */ marker for expandToItem. |
| src/components/mask-input/mask-input.ts | Adds Blazor analyzer markers for indirect render + visual children. |
| src/components/input/input-base.ts | Adds Blazor analyzer markers to the shared input base class. |
| src/components/date-time-input/date-time-input.ts | Adds Blazor analyzer markers to the date-time input component. |
| src/components/date-time-input/date-time-input.base.ts | Adds Blazor analyzer markers to the date-time input base class. |
| src/components/common/mixins/combo-box.ts | Adds /* omitModule */ and suppression markers for combo-box base mixins. |
damyanpetev
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Related Issues
Closes #
Testing
Checklist