fix(skills): omit column widths by default in generated grid code#227
Open
onlyexeption wants to merge 1 commit into
Open
fix(skills): omit column widths by default in generated grid code#227onlyexeption wants to merge 1 commit into
onlyexeption wants to merge 1 commit into
Conversation
onlyexeption
added
❌ status: awaiting-test
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the igniteui-blazor-grids skill reference docs to encourage generated grid code to omit per-column Width by default, improving responsive column distribution and avoiding empty right-side gaps unless fixed sizing is explicitly requested.
Changes:
- Removed explicit
Widthusage fromIgbGridLiteColumnexamples. - Added/updated “omit column
Widthby default” guidance in general grid rules (structure.md) and sizing rules (sizing.md). - Expanded sizing guidance around column virtualization when widths aren’t specified.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| skills/igniteui-blazor-grids/references/types.md | Removes explicit column Width from Grid Lite usage examples. |
| skills/igniteui-blazor-grids/references/structure.md | Adds a key rule to omit column Width unless explicitly requested. |
| skills/igniteui-blazor-grids/references/sizing.md | Moves “omit column Width” guidance into sizing rules and updates virtualization guidance. |
Comment on lines
+269
to
271
| 2. **Always set `Height` for performance** - without it, virtualization is disabled and all rows render to the DOM. | ||
| 2. **Percentage height needs a sized parent** - `Height="100%"` only works if the parent element has an explicit height. | ||
| 3. **Box model is border-box** - column widths include padding and borders. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #1696
Motivation / Context
Type of Change (check all that apply):
Component(s) / Area(s) Affected:
How Has This Been Tested?
Test Configuration:
Screenshots / Recordings
Checklist:
README.MDCHANGELOG.MDupdates for newly added functionalityCloses #