fix(grid): preserve refs and return new array to reflect changes - master#17321
Open
IvanKitanov17 wants to merge 2 commits into
Open
fix(grid): preserve refs and return new array to reflect changes - master#17321IvanKitanov17 wants to merge 2 commits into
IvanKitanov17 wants to merge 2 commits into
Conversation
IvanKitanov17
added
❌ status: awaiting-test
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes an issue where addRow() / deleteRow() updated the grid UI but not the original bound data source, by preserving the original data array reference while still ensuring the rendering pipeline receives updated array references when needed.
Changes:
- Updated
GridBaseAPIServiceto mutategrid.datain place for add/delete operations (preserving external references) and clear summary cache. - Updated
IgxGridTransactionPipeto return a new array reference whenpipeTriggerchanges, soigxGridForOfreliably detects updates even when the source array is mutated in place.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| projects/igniteui-angular/grids/core/src/common/pipes.ts | Ensures grid transaction pipeline produces updated array references for rendering refresh. |
| projects/igniteui-angular/grids/core/src/api.service.ts | Preserves bound data reference by mutating grid.data in place on add/delete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17317
Description
Motivation / Context
When using the addRow and deleteRow methods of the grid the data source is not being updated.
Type of Change (check all that apply):
Component(s) / Area(s) Affected:
Grids
How Has This Been Tested?
Test Configuration:
Screenshots / Recordings
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)