fix(grid-row-reorder): update row insertion logic during drag-and-drop#3971
Open
viktorkombov wants to merge 1 commit into
Open
fix(grid-row-reorder): update row insertion logic during drag-and-drop#3971viktorkombov wants to merge 1 commit into
viktorkombov wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the Grid row reordering sample so dragged rows are reinserted into the bound data array after grid.deleteRow(...), addressing the issue where the dragged row disappears instead of being reordered (Issue #3969).
Changes:
- Replaces in-place
splice(...)insertion with a new-array assignment (slice(...).concat(...)) to ensure the grid detects the data update after a drop.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
28
to
+30
| // remove the row that was dragged and place it onto its new location | ||
| this.grid.deleteRow(args.dragData.key); | ||
| this.data.splice(currRowIndex, 0, args.dragData.data); | ||
| this.data = this.data.slice(0, currRowIndex).concat(args.dragData.data, this.data.slice(currRowIndex)); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3969