fix(grid): fix advanced filtering grid styles#3962
Open
Hristo313 wants to merge 4 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to restore the custom styling for the Grid Advanced Filtering “custom styling” sample so it no longer falls back to default styles (per issue #3936).
Changes:
- Replaces the prior query-builder token theme approach with a set of dark-material themed component overrides (buttons, button-group, input-group, chip, drop-down) applied to the advanced filtering dialog.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
87
to
106
| :host { | ||
| @include tokens($custom-query-builder); | ||
| ::ng-deep { | ||
| igx-advanced-filtering-dialog { | ||
| @include theme($palette: $dark-material-palette); | ||
| @include css-vars($custom-button); | ||
| @include css-vars($custom-button-group); | ||
| @include css-vars($custom-input-group); | ||
| @include css-vars($custom-chip); | ||
| @include css-vars($custom-drop-down); | ||
| @include css-vars($flat-yellow); | ||
| @include css-vars($cancel-outlined); | ||
| @include css-vars($apply-contained); | ||
|
|
||
| .igx-button--contained, | ||
| .igx-excel-filter__clear > button.igx-button.igx-button--flat { | ||
| border: 1px solid $accent; | ||
| } | ||
| } | ||
| } | ||
| } |
Contributor
|
@simeonoff Is it ok to revert to the old custom styles for that sample? Or we should try different approach? @Hristo313 hgrid and treegrid adv. filtering samples also needs styling fixes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert the old custom styles for the advanced filtering
Closes #3936