feat(tui): Ctrl+P / Ctrl+N navigate slash-command autocomplete#3196
feat(tui): Ctrl+P / Ctrl+N navigate slash-command autocomplete#31961Git2Clone wants to merge 2 commits into
Conversation
Adds Emacs-style Ctrl+P (up) and Ctrl+N (down) as alternatives to arrow keys for navigating the inline slash-command popup when it is visible. Both arms gate on slash_menu_open and call the existing select_previous_slash_menu_entry / select_next_slash_menu_entry helpers — no new logic. Composer history handling already yields when the menu is open, so no conflict. Also updates KEYBINDINGS.md to document the new chords.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
|
Thanks @1Git2Clone for taking the time to contribute. This repository is observing a maintainer-managed PR intake gate in dry-run mode, so this pull request is staying open. This note helps maintainers prepare the allowlist before any enforcement is considered. Please read |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds Ctrl+P and Ctrl+N keybindings to navigate the slash-command palette menu, and updates the keybindings documentation accordingly. A conflict was identified where the global Ctrl+P keybinding (which opens the file picker) is handled earlier in the event loop, preventing the new navigation shortcut from working when the slash menu is open. A fix was suggested to ensure the file picker is not triggered when the slash menu is active.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
|
idk why my deepseek requested you as the reviewer Hmbown, I'm sorry for that 😔 at least it's just 10 lines of code I guess 
|
|
Now that I think about it—the Command Palette could also work the same way with @Hmbown do tell me if you want me to include that in the scope of this PR |
|
Thanks @1Git2Clone — your contribution landed in
Closing this PR now that the code is on If you want to land more work and would prefer your future PRs merge cleanly without a harvest step, the |
Adds Ctrl+P and Ctrl+N as Emacs-style alternatives for slash-command autocomplete navigation while keeping the global Ctrl+P file picker from stealing focus when the slash menu is open. Harvested from PR Hmbown#3196 by @1Git2Clone. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 participant
Summary
Adds Ctrl+P (up) and Ctrl+N (down) as alternatives to arrow keys for navigating the inline slash-command autocomplete popup. Includes an additional guard on the global Ctrl+P file-picker handler so it yields when the slash menu is open.
Verification