chore(ui): web UI cleanup — remove helios-web, topbar crumb, footer version#203
Open
angela-helios wants to merge 4 commits into
Open
chore(ui): web UI cleanup — remove helios-web, topbar crumb, footer version#203angela-helios wants to merge 4 commits into
angela-helios wants to merge 4 commits into
Conversation
…196) Now that crates/ui is the canonical UI crate: - Delete crates/web (helios-web), the superseded HTMX proof-of-concept. Nothing depends on it; drop it from default-members and the lockfile. - Remove the topbar Home breadcrumb that duplicated the page heading; right-align the topbar tools (justify-content: flex-end) and drop the unused .topbar__crumb rule. - Remove the hfs-version text from the Home status footer, keeping the last-checked timestamp. The version stays in the sidebar brand. Drop the status-version key from all three locale catalogs, the .status-line strong rule, and the now-purposeless .updated-at margin-left (it existed to space the timestamp off the version). Update the t_arg doc example that referenced status-version.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Follow-through on the #196 cleanup: with the version text gone, the remaining last-checked timestamp and refresh control carried no information the dashboard needs, so remove the footer altogether. - index.html: drop the status footer (partial include + refresh link). - Remove the now-unused action-refresh-status key from all three catalogs and the .status-footer / .status-line / .refresh CSS rules. - Keep the /ui/status handler and partial as the working reference for the fragment-vs-full-page pattern (still covered by the router and i18n HTTP tests); README updated to say the first real read paths will wire their own swap targets. - Retarget page-level test assertions from footer strings to nav strings (Home / Inicio / Startseite).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the three cleanups from #196, now that
crates/uiis the canonical UI crate:crates/web(helios-web) deleted — superseded PoC; removed fromdefault-members(themembersglob picks up the deletion) and fromCargo.lock. Workspace builds andhelios-uitests pass (27/27) without it..topbarnow usesjustify-content: flex-endso the tools stay right-aligned; dropped the unused.topbar__crumbrule.hfs vX). Dropped thestatus-versionkey from all three catalogs (parity test still green), the.status-line strongrule, and — one step beyond the issue list — the.updated-at { margin-left: 8px }rule, whose only purpose was spacing the timestamp off the now-gone version text. Updated thet_argdoc example that referencedstatus-version.Also carries the one-line ratification header flip for
docs/multi-language.md(from #187, ratified 2026-07-06) — folded in here per review preference instead of the standalone #202, which I am closing as superseded.Verified against the running server: no
topbar__crumbin the rendered page, fragment shows only the timestamp (still localized), sidebar still showshfs v0.2.1, CSS servesflex-end.Closes #196.
Update (650a87e): per follow-up feedback, the Home status footer is now removed entirely — the last-checked timestamp and the Refresh status control are gone along with the unused
action-refresh-statuskey and footer CSS. The/ui/statushandler and partial stay as the working reference for the fragment-vs-full-page pattern (still test-covered); the README notes the first real read paths will wire their own swap targets.