Skip to content

Improvements for joe#1217

Merged
dawsontoth merged 6 commits into
stagefrom
improvements-for-joe
May 29, 2026
Merged

Improvements for joe#1217
dawsontoth merged 6 commits into
stagefrom
improvements-for-joe

Conversation

@dawsontoth
Copy link
Copy Markdown
Contributor

No description provided.

@dawsontoth dawsontoth requested a review from a team as a code owner May 28, 2026 22:31
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces several UI adjustments, configuration updates, and bug fixes. Key changes include increasing API client timeouts to 60 seconds, fixing a typo in the session storage key for column visibility, refactoring the column picker component to use callbacks instead of an effect, and deduplicating parallel request timeout toasts. It also updates the comparator parsing logic to require separators for alphabetic operators.

Feedback is provided regarding a critical issue in the updated regular expression in getSearchByConditions.ts: because the regex is matched against a lowercase string, the uppercase T and Z in the character class will fail to match ISO timestamps. Additionally, trailing spaces are not handled, which can cause parsing failures. A suggestion has been provided to resolve both issues.

Comment thread src/integrations/api/instance/database/getSearchByConditions.ts
@dawsontoth dawsontoth merged commit d7e46bf into stage May 29, 2026
2 checks passed
@dawsontoth dawsontoth deleted the improvements-for-joe branch May 29, 2026 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant