506 show sponsored tracks not sending judges#508
Merged
michelleyeoh merged 4 commits intomainfrom Apr 28, 2026
Merged
Conversation
…e references across site
…acks and panel creation
There was a problem hiding this comment.
Pull request overview
This PR addresses #506 by centralizing the set of tracks judges should see (including sponsored tracks that are not sending judges) and wiring that unified set through judge scoring UI, ranking, panel creation, and judge-team matching logic.
Changes:
- Added
sponsoredNotSendingJudgesandjudgeVisibleTracksintracks.tsand updateddisplayNameToDomainMapto be based on the judge-visible set. - Replaced
optedHDTracksusage withjudgeVisibleTracksacross scoring, ranking, panels, and matching to ensure sponsored judge-visible tracks are included. - Removed a duplicate matching algorithm file and added focused Jest tests covering the new judge-visible behavior.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| app/_data/tracks.ts | Introduces sponsoredNotSendingJudges + judgeVisibleTracks and bases displayNameToDomainMap on judge-visible tracks. |
| app/(pages)/judges/(app)/_components/ScoringForm/ScoringForm.tsx | Uses judgeVisibleTracks so scoring questions render for judge-visible sponsored tracks. |
| app/(api)/_utils/scoring/rankTeams.ts | Filters/aggregates using judgeVisibleTracks so rankings include judge-visible sponsored tracks. |
| app/(api)/_utils/matching/judgesToTeamsAlgorithm.ts | Builds domain mapping from judgeVisibleTracks and refines non-judge track filtering to keep judge-visible sponsored tracks. |
| app/(api)/_utils/grouping/matchingAlgorithm.ts | Deletes duplicated/obsolete matching algorithm implementation. |
| app/(api)/_datalib/panels/createPanels.ts | Validates/creates panels against judgeVisibleTracks and uses its domain metadata. |
| app/(api)/_actions/logic/assignJudgesToPanels.ts | Initializes empty panels from judgeVisibleTracks rather than only opted-in HD tracks. |
| tests/rankTeams.sponsoredTrack.test.ts | Adds test coverage for ranking inclusion/exclusion based on judge-visible track set. |
| tests/judgesToTeamsAlgorithm.test.ts | Adds test verifying sponsored judge-visible tracks are kept while non-judge sponsor tracks are removed in matching. |
| tests/datalib/panels/createPanels.test.ts | Adds tests ensuring panel creation accepts judge-visible sponsored tracks and rejects non-judge-visible tracks. |
| mocks/tracks.ts | Updates tracks mock to include the new judge-visible exports and updated mapping behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
NO COMMENTS WOOOO |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #506
Changes: