Skip to content

CI: Add PDAF builds#82

Merged
jjokella merged 28 commits into
masterfrom
dev-pdaf-CI
Jun 3, 2026
Merged

CI: Add PDAF builds#82
jjokella merged 28 commits into
masterfrom
dev-pdaf-CI

Conversation

@jjokella
Copy link
Copy Markdown
Contributor

@jjokella jjokella commented Jul 11, 2025

Started from issue #81

Opening PR for testing CI.

Related PDAF-PR:

jjokella added 8 commits July 11, 2025 11:16
includes: commenting out unused variables in PDAF code
in order to get Oasis-files compiled correctly
Error
```
parflow_pdaf/pfsimulator/parflow_lib/solver_richards.c:1817:16: error:
unused variable ‘pfl_start’ [-Werror=unused-variable]
```

Background: In `PseudoAdvanceRichards`, there are many unused
variables.
branch matching current generic ParFlow from TSMP2
@kvrigor
Copy link
Copy Markdown
Member

kvrigor commented Jul 16, 2025

The issue seems to be the way ParFlow linker flags are manually specified:

if(DEFINED PARFLOW_SRC)
list(APPEND PDAF_LIBS "-L${CMAKE_INSTALL_PREFIX}/lib -lpfsimulator -lamps -lpfkinsol -lgfortran -lcjson")
# GPU
# list(APPEND PDAF_LIBS "-L${CMAKE_INSTALL_PREFIX}/rmm/lib -lstdc++ -lcudart -lrmm -lnvToolsExt")
list(APPEND PDAF_LIBS "-L${HYPRE_ROOT}/lib -lHYPRE")
list(APPEND PDAF_LIBS "-L/lib64 -lslurm")
endif()

The correct linker flags for ParFlow 3rd party dependencies (e.g. CUDA, Hypre) are generated by the ParFlow CMake scripts. Unfortunately TSMP2 cannot directly access these flags since they are dynamically generated. We need to find a way to extract these linker info from ParFlow.

jjokella and others added 8 commits May 28, 2026 16:18
Error from CI

```
 ./build_tsmp2.sh CLM35 ParFlow PDAF --OASIS_SRC /home/runner/work/TSMP2/TSMP2/oasis3-mct --no_update

Unknown parameter passed: CLM35
```
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@jjokella
Copy link
Copy Markdown
Contributor Author

jjokella commented May 28, 2026

@kvrigor With an update in loading SLURM/HYPRE, the eCLM/CLM3.5-ParFlow-PDAF builds now complete!

Side-Note: Temporary CI failure

I get a strange ICON standalone failure, but this should not be part of this CI.

Note: ICON standalone was failing due to temprorary connection failure to https://gitlab.dkrz.de/icon/icon-model re-running these checks, they complete (as they should with no changes wrt ICON).

@jjokella jjokella requested a review from kvrigor May 29, 2026 14:22
@jjokella
Copy link
Copy Markdown
Contributor Author

This turns the PR into

  1. An update of the main PDAF
  2. updates in the compilation scripts
    The from my side could be merged!

I am looking forward to the additional PDAF-related CI-tests!

Comment thread cmake/BuildParFlow.cmake
Comment thread cmake/BuildParFlow.cmake
Comment thread cmake/BuildParFlow.cmake
@kvrigor
Copy link
Copy Markdown
Member

kvrigor commented Jun 2, 2026

Also Johannes, please make sure to remove Claude as a co-author before you merge the PR. It's already transparent in the branch commits that LLM-assisted tooling was used, and whatever the tools to write the code, you are the one who did the difficult work of writing up this PR. Commit authorship imply code ownership; to me a "human author" is a good signal that signifies that some human author is ultimately responsible for the changes in the code, regardless of the tools used.

I think the list of commit authors in a repo, whatever tools used, should remain human. Besides, the prevalence of "Claude/Copilot" in Git repos nowadays look like free advertising to me 😅

jjokella added 2 commits June 2, 2026 13:50
- leads to wrong libraries loaded and ultimately runtime error

See #82 (comment)
@kvrigor
Copy link
Copy Markdown
Member

kvrigor commented Jun 3, 2026

I get a strange ICON standalone failure, but this should not be part of this CI.

Note: ICON standalone was failing due to temprorary connection failure to https://gitlab.dkrz.de/icon/icon-model re-running these checks, they complete (as they should with no changes wrt ICON).

Let's ignore it for now.. I'll fix this flaky test after this PR is merged.

@jjokella jjokella requested a review from kvrigor June 3, 2026 08:05
@jjokella jjokella merged commit c0490d5 into master Jun 3, 2026
14 checks passed
@jjokella jjokella deleted the dev-pdaf-CI branch June 3, 2026 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

eCLM-ParFlow-PDAF: HYPRE/SLURM library linking issue

2 participants