BuildPDAF: use FindLAPACK result variables for linking#131
Open
jjokella wants to merge 3 commits into
Open
Conversation
Using - `LAPACK_LIBRARIES` - `LAPACK_LINKER_FLAGS` should make the interface more robust for future compiler changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BuildPDAF.cmakewith the standardLAPACK_LIBRARIESandLAPACK_LINKER_FLAGSvariables populated by CMake'sFindLAPACKmoduleIntel/IntelLLVM/GNU) that mapped to different-qmkl/-mklflags and hardcoded MKL.sopathsSTATUSmessages forLAPACK_LIBRARIESandLAPACK_LINKER_FLAGSto aid debuggingMotivation
The previous approach hardcoded MKL library filenames and used compiler-specific flags, which was fragile and only partially portable (GNU path fell back to
LAPACK_LIBRARIESwith aWARNING, Intel path ignored it entirely). Sincefind_package(LAPACK REQUIRED)was already being called, using its output variables directly is the correct and portable approach.