Expose mediaType on ContentDescriptorTemplate#4499
Expose mediaType on ContentDescriptorTemplate#4499Sboti03 wants to merge 1 commit intoGoogleContainerTools:masterfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Code Review
This pull request removes an unused suppression annotation and adds a public getter for the mediaType field within the ContentDescriptorTemplate class. The reviewer recommends adding unit test assertions in V22ManifestTemplateTest and OciManifestTemplateTest to ensure the new getter correctly returns the expected data.
ee93d97 to
e5ab1e7
Compare
e5ab1e7 to
f7a8eec
Compare
|
@Sboti03 Thank you for your contribution. The lint checks are failing, would you mind reformatting the affected files? |
Motivation
ContentDescriptorTemplatestoresmediaTypebut does not expose it,while other descriptor fields (digest, size, urls, annotations) are accessible
via public getters.
This makes it difficult to work with OCI artifacts without using reflection.
Change
Adds a public getter:
Use case
Needed to inspect layer descriptors and select artifacts based on media type,
for example Helm chart layers:
application/vnd.cncf.helm.chart.content.v1.tar+gzipNotes
Fixes #4498 🛠️