chore(genai): replace deprecated genai image generation model#10254
Conversation
product-auto-label
Bot
added
the
samples
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the virtual try-on model ID to 'virtual-try-on-001' in the sample code and integration tests. It also removes the test scope for the 'google-cloud-storage' dependency in the pom.xml. A review comment points out that this dependency should remain in the test scope to avoid unnecessary compile-time dependencies and a larger artifact footprint.
| <groupId>com.google.cloud</groupId> | ||
| <artifactId>google-cloud-storage</artifactId> | ||
| <scope>test</scope> | ||
| </dependency> |
There was a problem hiding this comment.
The google-cloud-storage dependency is only used in the test classes (e.g., ImageGenerationIT.java) for cleaning up test resources. Removing the test makes it a compile-time dependency, which is unnecessary for the sample snippets and increases the artifact's footprint. It should remain in the test scope.
<scope>test</scope>
</dependency>
There was a problem hiding this comment.
@gemini-code-assist build is failing if the scope is set to test
There was a problem hiding this comment.
If the build is failing with <scope>test</scope>, it is likely because the google-cloud-storage dependency is being used in the main source code (e.g., src/main/java/...) rather than just in the test source code. If the main code requires this library, it must be a compile-time dependency, and the <scope>test</scope> tag should indeed be removed. Please verify if any classes in src/main/java/ import com.google.cloud.storage.
1 participant
Description
Fixes internal b/505834660
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
pom.xmlparent set to latestshared-configurationmvn clean verifyrequiredmvn -P lint checkstyle:checkrequiredmvn -P lint clean compile pmd:cpd-check spotbugs:checkadvisory only