Fix incorrect identifiers in PAKE operation example code#372
Merged
athoelke merged 2 commits intoJul 15, 2026
Conversation
The WPA3-SAE operation example referenced a PAKE step macro that is not
defined, and extracted the shared key from the wrong operation object (a
copy-paste from the SPAKE2+ example).
* The send-confirm counter input step used the undefined
PSA_PAKE_STEP_SEND_CONFIRM; the defined step is
PSA_PAKE_STEP_CONFIRM_COUNT.
* psa_pake_get_shared_key() operated on &spake2p_p instead of the
example's &wpa3_sae operation.
Signed-off-by: Chaitanya Tata <Chaitanya@dotstarsystems.com>
The SPAKE2+ operation example referenced a PAKE step macro that is not defined: the Prover input step for the Verifier confirmation value used the undefined PSA_PAKE_STEP_KEY_CONFIRM; the defined step is PSA_PAKE_STEP_CONFIRM. Signed-off-by: Chaitanya Tata <Chaitanya@dotstarsystems.com>
This was referenced Jul 12, 2026
athoelke
added
bug
athoelke
approved these changes
Jul 15, 2026
athoelke
left a comment
athoelke
left a comment
Collaborator
There was a problem hiding this comment.
Thank you very much for the contributed fixes - these are errors from cut-and-paste or API changes during development.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The SPAKE2+ and WPA3-SAE operation examples in the PAKE chapter
(
doc/crypto/api/ops/pake.rst) reference PAKE step macros that are notdefined anywhere in the specification, and the WPA3-SAE shared-key
extraction snippet operates on the wrong operation object. These are
copy/paste-style errors in the
.. code-block:: xrefexample snippets;they do not affect the normative text or the API.
Fixes
WPA3-SAE example
PSA_PAKE_STEP_SEND_CONFIRM,which is undefined. The defined step is
PSA_PAKE_STEP_CONFIRM_COUNT(
0x07), whose documented format is exactly "the 2-byte little-endiansend-confirm counter".
psa_pake_get_shared_key()operated on&spake2p_p(left over from theSPAKE2+ section) instead of the example's
&wpa3_saeoperation.SPAKE2+ example
PSA_PAKE_STEP_KEY_CONFIRM, which is undefined. The defined step isPSA_PAKE_STEP_CONFIRM(0x04), consistent with every otherconfirmation step in the same example.
A "Clarifications and fixes" entry is added to the document change history.
Notes
or dropped independently of the WPA3-SAE one.