fix: remove global lock optimization to align with Git#2674
Merged
Conversation
Previously, a transaction would rely on the packed-refs lock only when available, and skip per-ref locks entirely. This would, however, incorrectly serialise ref writers globally, giving it the same write performance as ref-tables, while allowing races with Git processes. Co-authored-by: Sebastian Thiel <sebastian.thiel@icloud.com>
Member
Author
|
This may very well have performance implication, but it would only be noticeable when fetching tremendous amounts of loose refs to write them, and… these would go directly to packed-refs anyway. Maybe back then, this optimisation didn't exist yet. So let's just fix it before an issue pops up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, a transaction would rely on the packed-refs lock
only when available, and skip per-ref locks entirely.
This would, however, incorrectly serialise ref writers globally,
giving it the same write performance as ref-tables, while allowing
races with Git processes.
Follow-up to #2659