feat: added trackById and JADM playback sample observer#44
Merged
Conversation
📝 WalkthroughWalkthroughThis PR adds track-by-ID lookup across Android and iOS, plus a playback-samples observer pattern for Android audio integration. The observer system lets multiple consumers subscribe to audio samples via thread-safe registration/removal. Track lookup scans local tracks first, then iterates peer connections to resolve receivers or senders by ID. ChangesTrack resolution and playback observer management
🎯 2 (Simple) | ⏱️ ~12 minutes
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
android/src/main/java/com/oney/WebRTCModule/WebRTCModuleOptions.java (1)
81-84: ⚡ Quick winDon’t expose mutable observer storage directly.
At Line 82, returning the live mutable list lets external callers bypass invariants enforced by add/remove. Return an unmodifiable view instead.
Suggested fix
import java.nio.ByteBuffer; +import java.util.Collections; import java.util.List; ... /** Iteration-safe; returns the live CopyOnWriteArrayList. */ public List<JavaAudioDeviceModule.PlaybackSamplesReadyCallback> getPlaybackSamplesObservers() { - return playbackSamplesObservers; + return Collections.unmodifiableList(playbackSamplesObservers); }🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@android/src/main/java/com/oney/WebRTCModule/WebRTCModuleOptions.java` around lines 81 - 84, getPlaybackSamplesObservers currently returns the live mutable playbackSamplesObservers list which allows external callers to modify observer storage; change getPlaybackSamplesObservers to return an unmodifiable view (e.g., Collections.unmodifiableList(playbackSamplesObservers)) so callers can iterate safely without bypassing the class's add/remove invariants — keep the internal field playbackSamplesObservers mutable and continue using the existing add/remove methods to manage observers.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@android/src/main/java/com/oney/WebRTCModule/WebRTCModuleOptions.java`:
- Around line 70-75: The addPlaybackSamplesObserver method currently appends
observers unconditionally which allows nulls and duplicates; update
addPlaybackSamplesObserver(JavaAudioDeviceModule.PlaybackSamplesReadyCallback
observer) to validate observer != null and only add if not already present in
playbackSamplesObservers (use playbackSamplesObservers.contains(observer)) to
make registration idempotent—silently ignore (or log) null/duplicate inputs
rather than adding them; this uses the existing playbackSamplesObservers field
and the JavaAudioDeviceModule.PlaybackSamplesReadyCallback type to locate the
change.
---
Nitpick comments:
In `@android/src/main/java/com/oney/WebRTCModule/WebRTCModuleOptions.java`:
- Around line 81-84: getPlaybackSamplesObservers currently returns the live
mutable playbackSamplesObservers list which allows external callers to modify
observer storage; change getPlaybackSamplesObservers to return an unmodifiable
view (e.g., Collections.unmodifiableList(playbackSamplesObservers)) so callers
can iterate safely without bypassing the class's add/remove invariants — keep
the internal field playbackSamplesObservers mutable and continue using the
existing add/remove methods to manage observers.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 2d46417f-a642-4b3b-ab69-a555ab209f99
📒 Files selected for processing (4)
android/src/main/java/com/oney/WebRTCModule/WebRTCModule.javaandroid/src/main/java/com/oney/WebRTCModule/WebRTCModuleOptions.javaios/RCTWebRTC/WebRTCModule.hios/RCTWebRTC/WebRTCModule.m
Comment on lines
+70
to
+75
| private final List<JavaAudioDeviceModule.PlaybackSamplesReadyCallback> playbackSamplesObservers = | ||
| new CopyOnWriteArrayList<>(); | ||
|
|
||
| public void addPlaybackSamplesObserver(JavaAudioDeviceModule.PlaybackSamplesReadyCallback observer) { | ||
| playbackSamplesObservers.add(observer); | ||
| } |
There was a problem hiding this comment.
Enforce non-null, de-duplicated observer registration.
At Line 73, registration appends unconditionally. A null or duplicate observer can lead to repeated callback failures or duplicate sample delivery when WebRTCModule fans out observers. Validate input and make add idempotent.
Suggested fix
import java.nio.ByteBuffer;
import java.util.List;
+import java.util.Objects;
import java.util.concurrent.Callable;
import java.util.concurrent.CopyOnWriteArrayList;
...
- private final List<JavaAudioDeviceModule.PlaybackSamplesReadyCallback> playbackSamplesObservers =
+ private final CopyOnWriteArrayList<JavaAudioDeviceModule.PlaybackSamplesReadyCallback> playbackSamplesObservers =
new CopyOnWriteArrayList<>();
public void addPlaybackSamplesObserver(JavaAudioDeviceModule.PlaybackSamplesReadyCallback observer) {
- playbackSamplesObservers.add(observer);
+ playbackSamplesObservers.addIfAbsent(Objects.requireNonNull(observer, "observer"));
}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| private final List<JavaAudioDeviceModule.PlaybackSamplesReadyCallback> playbackSamplesObservers = | |
| new CopyOnWriteArrayList<>(); | |
| public void addPlaybackSamplesObserver(JavaAudioDeviceModule.PlaybackSamplesReadyCallback observer) { | |
| playbackSamplesObservers.add(observer); | |
| } | |
| private final CopyOnWriteArrayList<JavaAudioDeviceModule.PlaybackSamplesReadyCallback> playbackSamplesObservers = | |
| new CopyOnWriteArrayList<>(); | |
| public void addPlaybackSamplesObserver(JavaAudioDeviceModule.PlaybackSamplesReadyCallback observer) { | |
| playbackSamplesObservers.addIfAbsent(Objects.requireNonNull(observer, "observer")); | |
| } |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@android/src/main/java/com/oney/WebRTCModule/WebRTCModuleOptions.java` around
lines 70 - 75, The addPlaybackSamplesObserver method currently appends observers
unconditionally which allows nulls and duplicates; update
addPlaybackSamplesObserver(JavaAudioDeviceModule.PlaybackSamplesReadyCallback
observer) to validate observer != null and only add if not already present in
playbackSamplesObservers (use playbackSamplesObservers.contains(observer)) to
make registration idempotent—silently ignore (or log) null/duplicate inputs
rather than adding them; this uses the existing playbackSamplesObservers field
and the JavaAudioDeviceModule.PlaybackSamplesReadyCallback type to locate the
change.
santhoshvai
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit