Skip to content

ci: make release version bump idempotent #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mogita merged 1 commit into from
Jun 18, 2026
Merged

ci: make release version bump idempotent #43

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions scripts/release/bump_version.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,15 +141,21 @@ function updateComposerVersion(string $path, string $version): void
throw new ReleaseScriptException('Could not read composer.json');
}

$count = 0;
$updated = preg_replace(
'/"version":\s*"[^"]*"/',
'"version": "v' . $version . '"',
$raw,
1
1,
$count
);

if ($updated === null || $updated === $raw) {
throw new ReleaseScriptException('Could not update version in composer.json');
if ($updated === null) {
throw new ReleaseScriptException('Regex failed while updating composer.json');
}

if ($count === 0) {
throw new ReleaseScriptException('Could not find version field in composer.json');
}

file_put_contents($path, $updated);
Expand Down
Loading