Skip to content

fix(Model): check new component uuid wrt other actual uuids in a model#1267

Open
panquez wants to merge 3 commits intonextfrom
fix/check-component-uuid
Open

fix(Model): check new component uuid wrt other actual uuids in a model#1267
panquez wants to merge 3 commits intonextfrom
fix/check-component-uuid

Conversation

@panquez
Copy link
Copy Markdown
Member

@panquez panquez commented May 7, 2026

No description provided.

@panquez panquez requested a review from BotellaA May 7, 2026 05:48
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 7, 2026

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-tidy (v20.1.8) reports: 3 concern(s)
  • include/geode/model/mixin/core/detail/components_storage.hpp:151:39: warning: [cppcoreguidelines-avoid-magic-numbers]

    36 is a magic number; consider replacing it with a named constant

      151 |                 if( filename.size() > 36 )
          |                                       ^
  • include/geode/model/mixin/core/detail/components_storage.hpp:153:68: warning: [cppcoreguidelines-avoid-magic-numbers]

    36 is a magic number; consider replacing it with a named constant

      153 |                     auto uuid = filename.substr( filename.size() - 36 );
          |                                                                    ^
  • include/geode/model/mixin/core/detail/components_storage.hpp:175:57: error: [clang-diagnostic-error]

    no member named 'StdSmartPtr' in namespace 'bitsery::ext'

      175 |                                     item, bitsery::ext::StdSmartPtr{} );
          |                                           ~~~~~~~~~~~~~~^

Have any feedback or feature suggestions? Share it here.

filename );
}
OpenGeodeModelException::check_exception( new_uuid, nullptr,
OpenGeodeException::TYPE::internal,
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not know how to decide if this is an internal or data error. This code cannot work because of its input parameters. Is it internal?

ComponentPtr& item ) {
archive2.object( component_id );
archive2.ext(
item, bitsery::ext::StdSmartPtr{} );
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing bitsery/ext/std_smart_ptr.h include ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants