chore(sdk-keys): clean up rtk_server_side_sdk_keys feature flag#7356
Merged
talissoncosta merged 4 commits intomainfrom Apr 29, 2026
Merged
chore(sdk-keys): clean up rtk_server_side_sdk_keys feature flag#7356talissoncosta merged 4 commits intomainfrom
talissoncosta merged 4 commits intomainfrom
Conversation
Inline the RTK-based SDK keys page into web/components/pages/sdk-keys/SDKKeysPage.tsx and remove the SDKEnvironmentKeysSettings indirection. The flag has shipped, so the wrapper that toggled between legacy and RTK paths is no longer needed. Refs #7140 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Now that the rtk_server_side_sdk_keys flag wrapper is gone, the Flux-era class component (web/components/ServerSideSDKKeys.js) and its host page (web/components/SDKKeysPage.tsx) are no longer referenced anywhere. Refs #7140 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The list endpoint returns APIKey[], so res?.id was always undefined and the extra tag entry was a no-op kept only to keep cache invalidation consistent with the legacy ServerSideSDKKeys.js component. The legacy component is gone, so collapse providesTags back to the LIST tag. Refs #7140 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The rtk_server_side_sdk_keys flag has shipped and the legacy code path is deleted, so the conditional skip is no longer needed. The test now runs unconditionally against the RTK page. Refs #7140 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit at claude.ai/admin-settings/claude-code.
Once credits are available, reopen this pull request to trigger a review.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
the
front-end
Contributor
Docker builds report
|
talissoncosta
changed the title
Contributor
Playwright Test Results (oss - depot-ubuntu-latest-16)
Details
Playwright Test Results (oss - depot-ubuntu-latest-arm-16)
Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-16)
Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)
Details
|
Contributor
Visual Regression16 screenshots compared. See report for details. |
kyle-ssg
approved these changes
Apr 29, 2026
talissoncosta
deleted the
chore/cleanup-rtk-server-side-sdk-keys-flag-7140
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Changes
Closes #7140
The
rtk_server_side_sdk_keysflag has shipped, so this PR removes the toggle and the legacy code it was guarding.refactor(sdk-keys): drop rtk_server_side_sdk_keys flag wrapper—web/components/pages/sdk-keys/SDKKeysPage.tsxis now the real page (formerlySDKEnvironmentKeysSettings.tsx), no flag check.chore(sdk-keys): remove legacy ServerSideSDKKeys and SDKKeysPage— deletes the orphaned Flux-era class component (web/components/ServerSideSDKKeys.js) and its host (web/components/SDKKeysPage.tsx).refactor(sdk-keys): drop redundant providesTags entry— collapsesuseGetServersideEnvironmentKeysQuery'sprovidesTagsback to the singleLISTtag (theres?.identry was a no-op kept for parity with the legacy component).test(e2e): always run server-side SDK keys test— drops theflagsmith.hasFeature('rtk_server_side_sdk_keys')skip so the test runs unconditionally.Follow-up (out of this PR): delete the
rtk_server_side_sdk_keysflag from Flagsmith once this is merged.How did you test this code?
npm run typecheck— no new errors introduced; remaining errors are pre-existing onmain.npx eslint --fixclean on touched files.grepconfirms no dangling references to legacy components or the flag string.sdk-keys-test.pw.tswill exercise the page end-to-end on CI.🤖 Generated with Claude Code