Skip to content

fix: render all top-level segment rules in the UI instead#7342

Draft
Zaimwa9 wants to merge 1 commit intomainfrom
fix/ui-only-displaying-first-top-level-rule
Draft

fix: render all top-level segment rules in the UI instead#7342
Zaimwa9 wants to merge 1 commit intomainfrom
fix/ui-only-displaying-first-top-level-rule

Conversation

@Zaimwa9
Copy link
Copy Markdown
Contributor

@Zaimwa9 Zaimwa9 commented Apr 24, 2026

Thanks for submitting a PR! Please check the boxes below:

  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

Closes #7254

  • Removed the hardcoded *rules[0] to properly deal with multiple top level rules

⚠️ Backend modification were overkill and might have required migrating all existing rules with multiple top level rules

How did you test this code?

  • Not yet

@Zaimwa9 Zaimwa9 requested a review from a team as a code owner April 24, 2026 16:53
@Zaimwa9 Zaimwa9 requested review from kyle-ssg and removed request for a team April 24, 2026 16:53
Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Code review skipped — your organization's overage spend limit has been reached.

Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit at claude.ai/admin-settings/claude-code.

Once credits are available, reopen this pull request to trigger a review.

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 24, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
flagsmith-frontend-preview Ready Ready Preview, Comment Apr 24, 2026 4:54pm
flagsmith-frontend-staging Ready Ready Preview, Comment Apr 24, 2026 4:54pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Ignored Ignored Apr 24, 2026 4:54pm

Request Review

@Zaimwa9 Zaimwa9 requested review from talissoncosta and removed request for kyle-ssg April 24, 2026 16:54
@Zaimwa9 Zaimwa9 marked this pull request as draft April 24, 2026 16:54
@github-actions github-actions Bot added front-end Issue related to the React Front End Dashboard fix labels Apr 24, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 24, 2026

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-7342 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-7342 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-7342 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-7342 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-7342 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-7342 Finished ✅ Results

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 24, 2026

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  11 passed

Details

stats  11 tests across 8 suites
duration  24.4 seconds
commit  ad79c58
info  🔄 Run: #16331 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  11 passed

Details

stats  11 tests across 8 suites
duration  11.4 seconds
commit  ad79c58
info  🔄 Run: #16331 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  17 passed

Details

stats  17 tests across 14 suites
duration  53.5 seconds
commit  ad79c58
info  🔄 Run: #16331 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  17 passed

Details

stats  17 tests across 14 suites
duration  58.9 seconds
commit  ad79c58
info  🔄 Run: #16331 (attempt 1)

@github-actions
Copy link
Copy Markdown
Contributor

Visual Regression

16 screenshots compared. See report for details.
View full report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix front-end Issue related to the React Front End Dashboard

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Segment UI only renders first top-level rule, silently drops additional rules

1 participant