Skip to content

Logged-out sign-in page URL shows /Home instead of root #94433

Draft
sumo-slonik wants to merge 3 commits into
Expensify:mainfrom
software-mansion-labs:fix/signin-page-root-url
Draft

Logged-out sign-in page URL shows /Home instead of root #94433
sumo-slonik wants to merge 3 commits into
Expensify:mainfrom
software-mansion-labs:fix/signin-page-root-url

Conversation

@sumo-slonik

@sumo-slonik sumo-slonik commented Jun 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Explanation of Change

The logged-out sign-in page showed /Home on web because PublicScreens registered SignInPage as SCREENS.HOME. Registering it under NAVIGATORS.TAB_NAVIGATOR (which has no path of its own) keeps the URL at the root /, and the related logout / 2FA reset paths are updated to match (with a /Home → / redirect kept for legacy cached paths).

Fixed Issues

$ #94450
PROPOSAL:

Tests

  1. Open the app on web while logged out.
  2. Verify the sign-in page is shown and the address bar URL is / (NOT /Home).
  3. Navigate directly to /Home while logged out and verify it redirects to /.
  4. Log in, then log out, and verify you land on the sign-in page with the URL /.
  5. While logged in on the Home tab, log out and verify the URL is / (NOT /home).
  6. Open a magic-link sign-in URL (/v/...) for an account that requires 2FA and verify the sign-in page appears at / with the authenticator-code step.
  7. Verify that no errors appear in the JS console.
  • Verify that no errors appear in the JS console

Offline tests

N/A — this change only affects unauthenticated navigation/URL resolution and has no offline-specific behavior.

QA Steps

Same as tests.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@sumo-slonik
Fix logged-out sign-in page URL to stay at the root
01ad27d 
PublicScreens registered the SignInPage under the top-level SCREENS.HOME, which has no root-level path mapping (it's only mapped as "home" nested in TAB_NAVIGATOR), so React Navigation derived "/Home" from the screen name. Logging out from the Home tab also surfaced "/home" because the post-logout reset carried over the nested tab focus.

Register the SignInPage under NAVIGATORS.TAB_NAVIGATOR instead, mirroring the authenticated top-level navigator (as it used to be registered under REPORTS_SPLIT_NAVIGATOR). TAB_NAVIGATOR has no path of its own, so the unauthenticated URL stays at "/". Update the post-logout and validate-login resets to target TAB_NAVIGATOR and drop any carried-over nested tab state so logout always lands on "/".
@sumo-slonik
Strengthen sign-in root URL tests with a PublicScreens render guard
3a9e15d 
- Add PublicSignInPageRootUrlTest: mounts the real PublicScreens navigator
  and asserts the root route renders SignInPage under TAB_NAVIGATOR and
  resolves to "/" (verified to fail if reverted to SCREENS.HOME).
- Rename getPathFromStatePublicHomeTest -> publicSignInPageUrlResolutionTest;
  drive the real linking config round-trip (getAdaptedStateFromPath ->
  getPathFromState), cover the legacy /Home -> / redirect, and fix the
  mislabeled authenticated-root case.
@sumo-slonik
Tighten sign-in root URL change: minimal comments, leaner tests
0ec6b72 
- Trim comments to behavior-only (drop change/history narration) across
  PublicScreens, getAdaptedStateFromPath, getStateToResetAfterLogout, types,
  and the ValidateLoginPage 2FA reset.
- Consolidate navigation tests into one PublicScreens render guard
  (renders SignInPage under TAB_NAVIGATOR at '/', plus the legacy /Home -> /
  redirect); remove the redundant getPathFromState resolution file.
- Make the test's jest.mock factory robust (mock-prefixed hoisted function
  declaration) instead of relying on module-load ordering.
@sumo-slonik sumo-slonik changed the title Fix/signin page root url Logged-out sign-in page URL shows /Home instead of root Jun 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@sumo-slonik sumo-slonik

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@sumo-slonik