Refactor HoldSubmitterEducationalModal to use CenteredModalLayout

[jmusial]

Explanation of Change

Fixed Issues

$ #90475
PROPOSAL:

Tests

Pre requisite:
It's easiest to start with a fresh account.

A. Single modal:

1. Open app & log in
2. Create an expense & open it
3. Open "More" dropdown & select "Hold"
4. Verify that Hold educational modal shows
5. Verify that after dismissing modal reason collection RHP opens
6. Verify that after entering reason expense is put on hold

B. Bulk modal:

1. Open app & log in
2. Create one or more expenses
3. Navigate to Spend/Expenses tab
4. Long press on an expense (or narrow screen to enable selection mode), select the number of expenses you want
5. Open "More" dropdown & select "Hold"
6. Verify that Hold educational modal shows
7. Verify that after dismissing modal reason collection RHP opens
8. Verify that after entering reason expense is put on hold

Dev tip:

Onyx.set('nvp_dismissedHoldUseExplanation', false)

to reset the modal

Offline tests

N/A

QA Steps

Same as tests

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

[jmusial]

@codex review

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 85c188b423

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[chatgpt-codex-connector]

Handle route removal for hold education

When this modal screen is removed via browser/native back navigation, neither onBackdropPress nor FeatureTrainingContent's onClose runs. The deleted component called useBeforeRemove(onClose), so this refactor now skips handleDismiss in both the single and bulk hold flows in that scenario; submitters who back out of the educational route won't set the dismissed NVP or continue to the hold action/reason page, so the hold attempt silently aborts.

Useful? React with 👍 / 👎.

[codecov]

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/SCREENS.ts	100.00% <ø> (ø)
src/components/MoneyReportHeaderModals.tsx	0.00% <ø> (ø)
src/components/MoneyReportHeaderModalsContext.tsx	22.22% <ø> (ø)
src/components/Search/SearchBulkActionsButton.tsx	1.61% <ø> (+0.02%)	⬆️
src/libs/Navigation/linkingConfig/config.ts	76.92% <ø> (ø)
src/ROUTES.ts	21.20% <0.00%> (-0.02%)	⬇️
.../components/MoneyRequestHeaderSecondaryActions.tsx	0.53% <0.00%> (+0.01%)	⬆️
src/hooks/useHoldRejectActions.ts	68.88% <50.00%> (ø)
src/hooks/useSearchBulkActions.ts	56.02% <0.00%> (+0.15%)	⬆️
...gator/Navigators/FeatureTrainingModalNavigator.tsx	8.33% <0.00%> (-1.67%)	⬇️
... and 4 more
... and 21 files with indirect coverage changes