Skip to content

[No QA] Skip loading unread indicator updater on Android#94428

Merged
mountiny merged 2 commits into
Expensify:mainfrom
callstack-internal:perf/skip-unread-updater-android
Jun 24, 2026
Merged

[No QA] Skip loading unread indicator updater on Android#94428
mountiny merged 2 commits into
Expensify:mainfrom
callstack-internal:perf/skip-unread-updater-android

Conversation

@TMisiukiewicz

@TMisiukiewicz TMisiukiewicz commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

updateUnread is a no-op on Android. Despite this, getUnreadReportsForUnreadIndicator was walking every report on each Onyx report/report-action/NVP/draft update, only to discard the result.

This PR stops loading the updater on Android entirely using the existing platform-file-extension convention already used in that folder:

  • New src/libs/UnreadIndicatorUpdater/load.ts (default — web/iOS): dynamically import('.') to register the Onyx subscriptions as before.
  • New src/libs/UnreadIndicatorUpdater/load.android.ts: no-op, so Metro excludes the updater module and its 5 Onyx subscriptions from the Android bundle.
  • src/SplashScreenStateContext.tsx now calls loadUnreadIndicatorUpdater() instead of inlining import('./libs/UnreadIndicatorUpdater').

Net effect: Android does zero report-walking for a result it never used. Web (tab title) and iOS (app icon badge) behavior is unchanged.

Fixed Issues

$ #94448
PROPOSAL:

Tests

Web:

  1. open the app in a browser
  2. send a message from another account
  3. verify the browser tab title updated to show the amount of unread messages

iOS

  1. Add the temporary log to src/libs/UnreadIndicatorUpdater/index.ts:
    just before updateUnread(unreadReports.length) inside triggerUnreadUpdate:
console.log('[UnreadIndicatorUpdater] unread count =', unreadReports.length);
  1. Open console and search for the log
  2. Verify the log is visible in the console

Android

  1. Verify the log above is not visible
  • Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Web:

  1. open the app in a browser
  2. send a message from another account
  3. verify the browser tab title updated to show the amount of unread messages

iOS

  1. Verify the icon badge with number of unread messages is displayed correctly
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

@codecov

codecov Bot commented Jun 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/SplashScreenStateContext.tsx 95.00% <100.00%> (ø)
src/libs/UnreadIndicatorUpdater/load.ts 100.00% <100.00%> (ø)
src/libs/UnreadIndicatorUpdater/load.android.ts 0.00% <0.00%> (ø)
... and 9 files with indirect coverage changes

@TMisiukiewicz TMisiukiewicz marked this pull request as ready for review June 24, 2026 10:51
@TMisiukiewicz TMisiukiewicz requested review from a team as code owners June 24, 2026 10:51
@melvin-bot melvin-bot Bot requested review from ZhenjaHorbach and trjExpensify and removed request for a team June 24, 2026 10:51
@melvin-bot

melvin-bot Bot commented Jun 24, 2026

Copy link
Copy Markdown

@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot Bot removed the request for review from a team June 24, 2026 10:51
@ZhenjaHorbach

ZhenjaHorbach commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
2026-06-24.13.31.54.mov
Android: mWeb Chrome
2026-06-24.13.17.53.mov
iOS: HybridApp
2026-06-24.13.16.51.mov
iOS: mWeb Safari
2026-06-24.13.17.53.mov
MacOS: Chrome / Safari
2026-06-24.13.14.43.mov

@melvin-bot melvin-bot Bot requested a review from mountiny June 24, 2026 12:05
mountiny
mountiny previously approved these changes Jun 24, 2026
@TMisiukiewicz TMisiukiewicz dismissed mountiny’s stale review June 24, 2026 12:13

The merge-base changed after approval.

mountiny
mountiny previously approved these changes Jun 24, 2026
@TMisiukiewicz TMisiukiewicz dismissed mountiny’s stale review June 24, 2026 12:19

The merge-base changed after approval.

mountiny
mountiny previously approved these changes Jun 24, 2026
@TMisiukiewicz TMisiukiewicz dismissed mountiny’s stale review June 24, 2026 12:24

The merge-base changed after approval.

madmax330
madmax330 previously approved these changes Jun 24, 2026
@TMisiukiewicz TMisiukiewicz dismissed madmax330’s stale review June 24, 2026 12:47

The merge-base changed after approval.

puneetlath
puneetlath previously approved these changes Jun 24, 2026
@TMisiukiewicz TMisiukiewicz dismissed puneetlath’s stale review June 24, 2026 12:55

The merge-base changed after approval.

@ZhenjaHorbach

ZhenjaHorbach commented Jun 24, 2026

Copy link
Copy Markdown
Contributor
image

@TMisiukiewicz
Let's try to update the branch to the latest version of main!

@mountiny

Copy link
Copy Markdown
Contributor

Lets burn this PR and create a new one

@ZhenjaHorbach

Copy link
Copy Markdown
Contributor

I think it's okay
Since in this PR we reused changes from this PR and we haven't updated the branch to the latest version of main yet
We have this issue

@ZhenjaHorbach

ZhenjaHorbach commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

@mountiny
Let's try again!

@mountiny mountiny merged commit 23fe44a into Expensify:main Jun 24, 2026
33 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.19-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@MelvinBot

Copy link
Copy Markdown
Contributor

🤖 No help site changes required.

This PR is an internal performance optimization with no user-facing behavior change:

  • It changes how the unread indicator updater is loaded — Android now skips loading the module entirely (since updateUnread was already a no-op there), while web (browser tab title) and iOS (app icon badge) behavior is unchanged.
  • The user-observable behavior is identical across all platforms before and after this change.

Expensify's help site (docs/articles) documents user-facing features and workflows, not bundle/loading internals. Since nothing changes for end users, there is no documentation to add or update.

No draft PR was created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants