Skip to content

perf: Search S5 ExpenseFlatSearchView + primitives#94426

Open
BartekObudzinski wants to merge 10 commits into
Expensify:mainfrom
callstack-internal:perf/search-s5-expense-flat-view
Open

perf: Search S5 ExpenseFlatSearchView + primitives#94426
BartekObudzinski wants to merge 10 commits into
Expensify:mainfrom
callstack-internal:perf/search-s5-expense-flat-view

Conversation

@BartekObudzinski

@BartekObudzinski BartekObudzinski commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

This changes how the flat expenses list renders on the Search screen. The expenses view (a plain, ungrouped transaction list) now renders through a new dedicated ExpenseFlatSearchView, which composes the reusable Search list building blocks (scroll restoration, horizontal table scroll, row exit animation, the selection header, and the row long-press menu) directly on top of BaseSearchList, instead of going through the larger shared SearchList.

`` still owns the data (a single useSearchSnapshot call), the screen lifecycle, and the selection providers — it just routes the flat-expenses view to the new component, while every other view (chat, task, report, grouped) keeps using `SearchList`. There is no intended user-facing change; behavior should be identical. This is an internal refactor to slim the expenses render path so it can evolve on its own.

Fixed Issues

$ #94455
PROPOSAL:

Tests

  1. Go to the Search tab and open the Expenses view (a flat, ungrouped list of expenses).
  2. Verify the expenses list loads with its table header and rows.
  3. Tap an expense row → it opens the expense details. Go back → the list returns to the same scroll position.
  4. Select a few expenses with the checkboxes, then use Select all → the header shows the correct selected count and bulk actions appear.
  5. On a wide screen, if the table is wider than the window, scroll horizontally → the columns scroll smoothly.
  6. Create a new expense from this page → it appears in the list with no crash.
  7. Delete an expense → the row animates out and the list updates.
  8. (Mobile) Long-press a row → it enters selection mode.
  • Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as tests

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

Screen.Recording.2026-06-24.at.13.20.46.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-06-24.at.13.00.47.mov

@codecov

codecov Bot commented Jun 24, 2026

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/components/Search/SearchList/index.tsx 49.22% <100.00%> (-2.21%) ⬇️
...c/components/Search/primitives/AnimatedExitRow.tsx 100.00% <100.00%> (ø)
...mponents/Search/primitives/useScrollRestoration.ts 100.00% <100.00%> (ø)
...onents/Search/primitives/HorizontalTableScroll.tsx 77.77% <77.77%> (ø)
src/components/Search/ExpenseFlatSearchView.tsx 88.67% <88.67%> (ø)
src/components/Search/index.tsx 0.74% <0.00%> (-0.02%) ⬇️
...c/components/Search/primitives/SelectionTopBar.tsx 0.00% <0.00%> (ø)
...mponents/Search/primitives/useRowLongPressMenu.tsx 62.06% <62.06%> (ø)
... and 74 files with indirect coverage changes

@BartekObudzinski BartekObudzinski changed the title [No QA] perf: Search S5 ExpenseFlatSearchView + primitives perf: Search S5 ExpenseFlatSearchView + primitives Jun 24, 2026
@BartekObudzinski BartekObudzinski marked this pull request as ready for review June 24, 2026 11:30
@BartekObudzinski BartekObudzinski requested review from a team as code owners June 24, 2026 11:30
@melvin-bot melvin-bot Bot requested review from Pujan92 and joekaufmanexpensify and removed request for a team June 24, 2026 11:30
@melvin-bot

melvin-bot Bot commented Jun 24, 2026

Copy link
Copy Markdown

@Pujan92 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a036eefca0

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/components/Search/ExpenseFlatSearchView.tsx
Comment thread src/components/Search/primitives/SelectionTopBar.tsx
Comment thread src/components/Search/ExpenseFlatSearchView.tsx
Comment thread src/components/Search/index.tsx
@BartekObudzinski

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a036eefca0

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/components/Search/ExpenseFlatSearchView.tsx
@joekaufmanexpensify

Copy link
Copy Markdown
Contributor

No product review needed

@joekaufmanexpensify joekaufmanexpensify removed their request for review June 24, 2026 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants