perf: Search S5 ExpenseFlatSearchView + primitives#94426
perf: Search S5 ExpenseFlatSearchView + primitives#94426BartekObudzinski wants to merge 10 commits into
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a036eefca0
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a036eefca0
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
No product review needed |
Explanation of Change
This changes how the flat expenses list renders on the Search screen. The expenses view (a plain, ungrouped transaction list) now renders through a new dedicated
ExpenseFlatSearchView, which composes the reusable Search list building blocks (scroll restoration, horizontal table scroll, row exit animation, the selection header, and the row long-press menu) directly on top ofBaseSearchList, instead of going through the larger sharedSearchList.`` still owns the data (a single
useSearchSnapshotcall), the screen lifecycle, and the selection providers — it just routes the flat-expenses view to the new component, while every other view (chat, task, report, grouped) keeps using `SearchList`. There is no intended user-facing change; behavior should be identical. This is an internal refactor to slim the expenses render path so it can evolve on its own.Fixed Issues
$ #94455
PROPOSAL:
Tests
Offline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)Avatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
Screen.Recording.2026-06-24.at.13.20.46.mov
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-06-24.at.13.00.47.mov