Skip to content

Audit react-navigation patches: remove redundant emoji patch, fix stale docs#94419

Draft
elirangoshen wants to merge 1 commit into
Expensify:mainfrom
callstack-internal:fix/2632-rn-patch-cleanup
Draft

Audit react-navigation patches: remove redundant emoji patch, fix stale docs#94419
elirangoshen wants to merge 1 commit into
Expensify:mainfrom
callstack-internal:fix/2632-rn-patch-cleanup

Conversation

@elirangoshen

@elirangoshen elirangoshen commented Jun 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Explanation of Change

This addresses the internal callstack audit callstack-internal/expensify-issues#2632 — "Verify and update react-navigation's patches". A react-navigation maintainer (Satya164) flagged several of our custom patches in patches/react-navigation/ as possibly outdated. We audited every patch against upstream react-navigation. This PR lands the low-risk cleanup only; the v8-dependent migrations are documented inline as follow-ups and are intentionally not done here.

Changes (2 files, +3/-30):

  • Removed @react-navigation+core+7.16.1+002+fix-crash-when-parsing-emoji.patch. The emoji crash fix (upstream react-navigation PR #12679) is already shipped in the installed @react-navigation/core@7.16.1. The local patch's "before" line was already the fixed code; all the patch actually did was strip the String() wrapper (Array.from(String(value)) → Array.from(value)), which is not the upstream fix and is a mild regression for non-string values. Removing it restores upstream's emoji-safe behavior on the next install.
  • patches/react-navigation/details.md:
    • Removed the stale getStateFromPath.patch entry — that patch file was deleted back in June 2025; only the doc entry survived.
    • Fixed the incorrect upstream link on the browser-history patch (@react-navigation+native+7.1.33+001+initial.patch). It pointed to PR Web -Chat - Error message displayed when sending message from corrupted accounts #11887 (which is actually the InteractionManager PR — a copy-paste error); now corrected to PR #12751 (route.history + pushParams, which Satya added upstream for this exact use case) plus the originating issue #12460.
    • Annotated the native-stack InteractionManager patch: its Web -Chat - Error message displayed when sending message from corrupted accounts #11887 link is correct (that PR was closed/declined upstream, so we re-implement it); still required on v7 (runAfterInteractions is widely used); v8 removes InteractionManager support, so consumers will move to navigation.addListener('transitionEnd', ...).
    • Annotated the dontDetachScreen patch with the v8 inactiveBehavior follow-up.

Follow-ups intentionally NOT in this PR (all require the React Navigation v8 upgrade, which is alpha-only and blocked on a react-native-screens rewrite):

  • Adopt pushParams to shrink the browser-history patch.
  • Migrate InteractionManager consumers to transitionEnd.
  • Replace dontDetachScreen with inactiveBehavior.

Fixed Issues

$ N/A — This is tracked by an internal callstack issue (callstack-internal/expensify-issues#2632), not a public Expensify/App GitHub issue, so there is no public $-linkable issue number. The audit referenced above is the source of record.
PROPOSAL: N/A — Internal maintenance/cleanup task; no public proposal process applies.

Tests

  1. On a clean checkout of this branch, run npm install and verify patch-package applies the remaining react-navigation patches with no errors and without the removed emoji patch.
  2. Verify patches/react-navigation/@react-navigation+core+7.16.1+002+fix-crash-when-parsing-emoji.patch no longer exists and is not referenced anywhere.
  3. Open patches/react-navigation/details.md and verify: no getStateFromPath.patch entry; the browser-history patch links to PR Update version to 1.2.28-0 on main #12751 / issue Add errors object back to menu item, remove unused isPolicy #12460; the InteractionManager and dontDetachScreen entries carry the v8 follow-up annotations.
  4. Smoke-test navigation (push/pop screens, deep links, browser back/forward on web) and confirm behavior is unchanged — this is a documentation + dead-patch removal change with no runtime behavior change on v7 (the emoji fix is already in the installed package).
  • Verify that no errors appear in the JS console

Offline tests

No offline-specific behavior is affected. This PR only removes a redundant build-time patch and updates patch documentation; there is no runtime, network, or data-layer change.

QA Steps

Same as Tests. There is no user-facing behavior change to validate on staging — the removed patch's behavior is already provided by the installed @react-navigation/core@7.16.1.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-06-24.at.15.30.53.mov
Screen.Recording.2026-06-24.at.15.32.23.mov

@elirangoshen @claude
Audit react-navigation patches: remove redundant emoji patch, fix sta…
023ab92 
…le docs

- Remove fix-crash-when-parsing-emoji patch (Expensify#12679 already in core@7.16.1;
  patch only stripped String() coercion, not the upstream fix)
- Remove stale getStateFromPath entry from details.md (file deleted Jun 2025)
- Fix wrong Expensify#11887 upstream link on browser-history patch -> Expensify#12751/Expensify#12460
- Document v8 follow-ups (transitionEnd, inactiveBehavior, pushParams)

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@github-actions

github-actions Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@elirangoshen elirangoshen

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@elirangoshen