Show complete Certinia bundle instructions#94414
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
|
@ChavdaSachin @thelullabyy One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
@codex review |
|
@ShridharGoel Hey, I think translations should be done through this workflow #94414 (comment) |
|
We can run the workflow to check if it creates any diff on top of the translations added here |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8e2666faf9
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| <Text style={[styles.textStrong, styles.mb2]}>{translate('workspace.certinia.prerequisites.installBundlePSAHeader')}</Text> | ||
| <RenderHTML | ||
| html={translate('workspace.certinia.prerequisites.installBundlePSADescription', { | ||
| href: CONST.CERTINIA_PSA_BUNDLE_INSTALL_URL.PRODUCTION, |
There was a problem hiding this comment.
Select sandbox installer links in sandbox flow
When users enter the sandbox Certinia prerequisites flow, this always renders the production PSA installer URL even though this route already carries an optional isSandbox param and CONST defines sandbox package URLs. That sends sandbox admins to login.salesforce.com instead of the sandbox installer, so they can install the bundle into the wrong Salesforce org; use the route’s sandbox flag to choose SANDBOX for the bundle links before rendering them.
Useful? React with 👍 / 👎.
Explanation of Change
Updates Certinia setup step 1 to show the complete bundle installation instructions.
The step now:
Fixed Issues
$ #89433
PROPOSAL: N/A
Tests
Offline tests
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)Avatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos