Fix: keep input focus by dismissing keyboard only when IOU type actually changes

[MelvinBot]

Explanation of Change

When tracking an expense from the FAB (selecting personal space in the "To" section), every keystroke in the amount/merchant/description fields was un-focusing the input.

The root cause is in resetIOUTypeIfChanged inside src/hooks/useResetIOUType.ts. Keyboard.dismiss() was being called unconditionally at the top of the function, before the early-return guard that bails out when the IOU request type hasn't actually changed (transaction?.iouRequestType === newIOUType). Because the function runs on each render of that flow while the type is unchanged, the keyboard (and input focus) was dismissed on every input.

This change reorders the logic so the early-return runs first and Keyboard.dismiss() only fires when the IOU type is genuinely changing — which is the only case that warrants dismissing the keyboard.

Fixed Issues

$ #94273
PROPOSAL:

Tests

1. Sign in to staging.new.expensify.com
2. Click on FAB > Create expense
3. In the "To" section Click and select personal space ( You )
4. Enter amount in the amount field/ Merchant field / Description from digital keyboard
5. Verify that All fields are focused until the user moves to another field

• Verify that no errors appear in the JS console

Offline tests

1. Sign in to staging.new.expensify.com
2. Click on FAB > Create expense
3. In the "To" section Click and select personal space ( You )
4. Enter amount in the amount field/ Merchant field / Description from digital keyboard
5. Verify that All fields are focused until the user moves to another field

QA Steps

1. Sign in to staging.new.expensify.com
2. Click on FAB > Create expense
3. In the "To" section Click and select personal space ( You )
4. Enter amount in the amount field/ Merchant field / Description from digital keyboard
5. Verify that All fields are focused until the user moves to another field

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

[MelvinBot]

I created this PR from an upstream branch since I don't have push access to your fork.

To take ownership of this branch and be able to push updates, run:

git remote add upstream https://github.com/Expensify/App.git
git fetch upstream claude-reorderKeyboardDismissResetIOUType
git checkout -b claude-reorderKeyboardDismissResetIOUType upstream/claude-reorderKeyboardDismissResetIOUType
git push -u origin claude-reorderKeyboardDismissResetIOUType

Then you can close this PR and open a new one from your fork.

[thelullabyy]

@MelvinBot Please replace all [ ] by [x] in PR description

Besides, let's add this test into Test and QA section

1. Sign in to staging.new.expensify.com
2. Click on FAB > Create expense
3. In the "To" section Click and select personal space ( You )
4. Enter amount in the amount field/ Merchant field / Description from digital keyboard
5. Verify that All fields are focused until the user moves to another field

Finally, open PR for ready (mark it as ready)

[melvin-bot]

@jayeshmangwani Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[thelullabyy]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
• I verified tests pass on all platforms & I tested again on:
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-06-24.at.02.22.14.mov

[MelvinBot]

🤖 Done, thelullabyy:

• ✅ Replaced all [ ] with [x] throughout the PR description.
• ✅ Added the focus test steps to the Tests, Offline tests, and QA Steps sections.
• ✅ Marked the PR as Ready for review.

[thelullabyy]

@jayeshmangwani Sorry but please ignore the assignment, I will review this PR

[thelullabyy]

LGTM

[trjExpensify]

Same, looks good. 👍

[puneetlath]

@thelullabyy @MelvinBot the Author checklist is failing.

[MelvinBot]

The failing PR Author Checklist check is a stale older run — no code change is needed.

• The first run failed at 06:29 UTC with PR Author Checklist is not completely filled out because the checklist boxes weren't all checked yet.
• The boxes have since all been checked, and a newer run at 18:54 UTC for the same commit (e055ee7) passed ✅.

The red is just the older run lingering. Re-running the failed PR Author Checklist job (Actions → Re-run failed jobs) will clear it — I don't have permission to trigger the re-run myself.

[puneetlath]

@MelvinBot I just re-ran it and it's still failing.

[MelvinBot]

Correcting my earlier comment — that was wrong. The green "checklist" is the PR Reviewer Checklist (a different workflow); the PR Author Checklist has genuinely never passed on this PR.

Why re-running doesn't fix it: the PR Author Checklist runs on the pull_request_target event. Re-running a failed job replays the original event payload captured at 06:29 UTC — when the checklist boxes were still unchecked — so it will always fail no matter how many times you re-run it. It never looks at the current PR body.

The fix: trigger a fresh event so it re-evaluates the current body (which now has all 19 boxes checked, 0 unchecked → it will pass). Any of these works:

• Edit the PR description and save (fires edited), or
• Push any commit to the branch (fires synchronize), or
• Close and reopen the PR (fires reopened).

Editing the description (even a trivial no-op change) is the quickest. I didn't do it myself since this is the author checklist and I don't want to silently mutate your PR — but say the word and I can push an empty commit to re-trigger it.

[thelullabyy]

@MelvinBot You are using wrong PR author template. It should be this one https://raw.githubusercontent.com/Expensify/App/main/.github/PULL_REQUEST_TEMPLATE.md

[MelvinBot]

Good catch — I've updated the PR description to use the current PULL_REQUEST_TEMPLATE.md. The previous body used an outdated, truncated PR Author Checklist that was missing many of the current items. The Explanation, Fixed Issues, Tests, Offline tests, QA Steps, and Screenshots sections are preserved.

[thelullabyy]

@puneetlath all good now

[github-actions]

🚧 puneetlath has triggered a test Expensify/App build. You can view the workflow run here.

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #94412.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-976fdba012a-08be844-f670736a899cca24cd51b4df5abb85b4289068ae/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-976fdba-08be844-eaa69b97323237746a3f9833107bf23edf2d2663/index.html

Web 🕸️
https://94412.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀