Update Subscription settings from editable push row to a read-only row with an Edit subscription button#94363
Update Subscription settings from editable push row to a read-only row with an Edit subscription button#94363lorretheboy wants to merge 1 commit into
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
|
@gijoe0295 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@neil-marcellini Could you please trigger the translation workflow? |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 13d5e2e951
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| /> | ||
| <View style={[style, styles.mt2]}> | ||
| <Button | ||
| text={translate('subscription.subscriptionSettings.editSubscription')} |
There was a problem hiding this comment.
Add translations for the new button label
When the user's locale is any non-English locale, this new translate('subscription.subscriptionSettings.editSubscription') lookup has no corresponding entry in the generated locale files (de/es/fr/it/ja/nl/pl/pt-BR/zh-hans). Missing locale keys are surfaced by translate, so localized users can see the raw key or missing-translation text for this subscription button until the locale files are updated with the new label.
Useful? React with 👍 / 👎.
Explanation of Change
Fixed Issues
$ #93168
PROPOSAL: #93168 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)Avatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
44.mov
Android: mWeb Chrome
Screen.Recording.2026-06-23.at.16.43.33.mov
iOS: Native
33.mov
iOS: mWeb Safari
22.mov
MacOS: Chrome / Safari
1.mov