[No QA] Update approval types and backup approver details#94350
[No QA] Update approval types and backup approver details#94350Christinadobrzyn wants to merge 1 commit into
Conversation
- Clarified the role of designated approvers and default approvers in the approval process. - Related Slack convo - https://expensify.slack.com/archives/C08FETQ0UKE/p1782161828609669?thread_ts=1780939034.263089&cid=C08FETQ0UKE
|
@strepanier03 - Let's hold on to this for a moment. I've asked Tides.org to test these changes on their side (I've already tested and they work). I just want to make sure they see the same before we deploy these changes. I'll follow up when we can continue this update. |
| - **Manager Approval**: Uses the manager from the member's Expensify workflow. | ||
| - **Designated Approver**: Sends bookings to a pre-defined approver. | ||
| - **Default Approvers**: Add up to three backups to handle approval volume, especially when using Hard Approval or Pre-Booking Approval. | ||
| - **Designated Approver and selecting "Add employee's manager to cc"**: an approval email will be sent to the workspace approver and also specific pre-defined approvers. Add up to three backups to handle approval volume, especially when using Hard Approval or Pre-Booking Approval. |
There was a problem hiding this comment.
UI referencing violation: Do not wrap UI labels in quotation marks (HELPSITE_NAMING_CONVENTIONS.md — Core UI Referencing Rules / Button Naming). Bold the exact UI label instead of quoting it. Also, the bold label should be the exact UI element name only — it currently merges the Designated Approver option with a separate setting into one bold phrase. Reference the toggle/checkbox label on its own, e.g. enable Add employee's manager to cc.
|
A preview of your ExpensifyHelp changes have been deployed to https://6d2d2324.helpdot.pages.dev ⚡️ Updated articles: |
| - **Manager Approval**: Uses the manager from the member's Expensify workflow. | ||
| - **Designated Approver**: Sends bookings to a pre-defined approver. | ||
| - **Default Approvers**: Add up to three backups to handle approval volume, especially when using Hard Approval or Pre-Booking Approval. | ||
| - **Designated Approver and selecting "Add employee's manager to cc"**: an approval email will be sent to the workspace approver and also specific pre-defined approvers. Add up to three backups to handle approval volume, especially when using Hard Approval or Pre-Booking Approval. |
There was a problem hiding this comment.
Readability: The sentence after the colon begins lowercase ("an approval email..."). Start with a capital letter for consistency and scannability (HELP_AUTHORING_GUIDELINES.md — Step Formatting / clear, action-oriented).
| - **Designated Approver**: Sends bookings to a pre-defined approver. | ||
| - **Default Approvers**: Add up to three backups to handle approval volume, especially when using Hard Approval or Pre-Booking Approval. | ||
| - **Designated Approver and selecting "Add employee's manager to cc"**: an approval email will be sent to the workspace approver and also specific pre-defined approvers. Add up to three backups to handle approval volume, especially when using Hard Approval or Pre-Booking Approval. | ||
| - **Default Approvers**: If a workspace employee doesn't have an approver in the workspace, this individual will get the approval email. If you select a Manager Approval, you must also set a Default Approver. |
There was a problem hiding this comment.
Terminology violation: Use "member" instead of "employee"/"workspace employee" to match Expensify standards (HELP_AUTHORING_GUIDELINES.md — exact UI terminology). For example: "If a workspace member doesn't have an approver...".
| - **Designated Approver**: Sends bookings to a pre-defined approver. | ||
| - **Default Approvers**: Add up to three backups to handle approval volume, especially when using Hard Approval or Pre-Booking Approval. | ||
| - **Designated Approver and selecting "Add employee's manager to cc"**: an approval email will be sent to the workspace approver and also specific pre-defined approvers. Add up to three backups to handle approval volume, especially when using Hard Approval or Pre-Booking Approval. | ||
| - **Default Approvers**: If a workspace employee doesn't have an approver in the workspace, this individual will get the approval email. If you select a Manager Approval, you must also set a Default Approver. |
There was a problem hiding this comment.
Formatting: Remove the trailing whitespace at the end of this line (pre-publish cleanliness).
|
HelpDot Documentation Review Overall Assessment Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: Detailed line-by-line feedback has been provided as inline comments. |
|
Hi @strepanier03! Tides confirmed the approval emails worked. We can move forward with these updates to the help article. Please let me know if you have any questions about my suggestions! Thanks for reviewing! |
Explanation of Change
Fixed Issues
$
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)Avatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari