Fix parquet compression handling in aws_s3 sink#37
Merged
sundaresanr merged 1 commit intov0.54.0-exaforcefrom Apr 21, 2026
Merged
Fix parquet compression handling in aws_s3 sink#37sundaresanr merged 1 commit intov0.54.0-exaforcefrom
sundaresanr merged 1 commit intov0.54.0-exaforcefrom
Conversation
Two bugs caused parquet sinks to emit unreadable files unless users explicitly set compression: none: 1. Sink-level `compression` (default gzip) wrapped the parquet bytes, so the S3 object started with gzip magic instead of PAR1 — DuckDB and Snowflake rejected it. 2. Parquet internal compression was hardcoded to UNCOMPRESSED, and the parquet crate was built without snap/flate2/zstd features so even trying SNAPPY would panic at runtime. Fix: when codec=parquet, feed the sink-level compression into the parquet writer's WriterProperties and force transport-layer compression to None. Non-parquet codecs are unaffected. Vector Compression -> parquet: None -> UNCOMPRESSED, Snappy -> SNAPPY, Gzip -> GZIP, Zstd -> ZSTD. Zlib rejected at build time (no parquet equivalent). Also fixes a broken test import (vrl::value::btreemap was made private) so the parquet test module actually compiles.
sundaresanr
force-pushed
the
parquet-compression
branch
from
62ac478 to
5825924
Compare
LotharKAtt
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parquet sinks were producing unreadable files unless users explicitly set
compression = nonedue to two issues:compression(default: gzip) wrapped parquet output,causing S3 objects to start with gzip magic bytes instead of PAR1.
This led to ingestion failures in systems like DuckDB and Snowflake.
built without compression features (snappy, flate2, zstd), causing
runtime panics when other compression types were attempted.
Fix:
codec = parquet, pass sink-level compression into parquetWriterProperties(internal compression).Noneto avoid double wrapping.Compression mapping: