Fix compile errors on v0.51-exaforce#32
Closed
sundaresanr wants to merge 1 commit intov0.51-exaforcefrom
Closed
Conversation
- Add ParquetSerializer, ParquetSerializerConfig, ParquetSerializerOptions to the format:: import block in serializer.rs (7 E0412/E0433 errors). - Fix SerializerConfig::Gelf match arm in build_batched() — the enum is Gelf(GelfSerializerConfig), not a unit variant (E0532). - Drop `ref mut` from BoolColumnWriter match arm in parquet.rs — Rust 2024 match ergonomics disallow it when binding mode is already `move`. Verified with `cargo check -p codecs`.
Author
|
Closing — the 3 fixes get Superseding with a new PR that drops the azure_blob queue source and GCP impersonation patches (both confirmed unused in production Vector configs) and keeps only the parquet codec. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Unblocks the
Publishworkflow onv0.51-exaforce, which has been red on every push since Nov 2025.Three mechanical fixes, all in
lib/codecs:encoding/serializer.rs— addParquetSerializer,ParquetSerializerConfig,ParquetSerializerOptionsto theuse super::format::{ ... }block. Resolves 7 E0412/E0433 errors (lines 124/255/326/350/624/627/628).encoding/serializer.rs:260—SerializerConfig::Gelf→SerializerConfig::Gelf(..). The enum definesGelf(GelfSerializerConfig)(tuple variant); the match arm inbuild_batched()was using unit-variant syntax. Resolves E0532.encoding/format/parquet.rs:302— dropref mutfromBoolColumnWriter(ref mut writer). Rust 2024 match-ergonomics disallows explicitref mutwhen default binding mode is alreadymove. The sibling arms (Int64ColumnWriter(writer), etc.) already use the bare form.Local verification:
cargo check -p codecs— green.