test(ensemble): cover navigateViewGroup clamp and CDN stale refresh#2263
Draft
cursor[bot] wants to merge 1 commit into
Draft
test(ensemble): cover navigateViewGroup clamp and CDN stale refresh#2263cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
- Extract resolveNavigateViewGroupTabIndex for navigateViewGroup index clamping - Extract CDN stale refresh outcome logic with @VisibleForTesting hooks - Add tests for cold-start immediate bundle sync vs deferred pending updates Co-authored-by: Sharjeel Yunus <sharjeelyunus@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Risky behavior now covered
navigateViewGroupindex clamping (0ce6723a):resolveNavigateViewGroupTabIndexlocks in the rule that out-of-range indices are clamped beforePageController.jumpToPagewhen the menu has items, while preserving the raw index whenmenuLen == 0(PageGroup not mounted).19b50b2e):_applyStaleRefreshOutcome/shouldApplyCdnStaleRefreshImmediatelycover the cold-start path where artifact refresh is enabled and the app is initialized—bundle sync happens immediately instead of deferring to resume, preventing screens from rebuilding with stale resources.Test files added/updated
modules/ensemble/test/safe_view_group_payload_index_test.dart—resolveNavigateViewGroupTabIndexclamp and zero-menu edge casesmodules/ensemble/test/cdn_provider_test.dart— stale refresh decision matrix and immediate vs deferred bundle syncWhy these tests materially reduce regression risk
viewIndexbeforejumpToPagewould crash or land on the wrong tab when payloads shrink; the extracted helper makes that contract explicit and unit-testable without a full widget tree.Validation
All 15 tests passed.