feat: add url and name to alp admin overview#151
Open
ahuininga-orisha wants to merge 12 commits into
Open
Conversation
…d collection parent::getSelectCountSql() strips GROUP BY and clones the SELECT without re-running _beforeLoad, so the store join is absent in the count query. HAVING clauses referencing GROUP_CONCAT aggregates then cause a fatal SQL error (SQLSTATE[42S22]: unknown column) when any name/store_urls filter is active, breaking admin grid pagination entirely. Fix: override getSelectCountSql() to re-add the join and GROUP BY when a HAVING clause is present, then wrap in a subquery so MySQL returns a single COUNT(*) instead of one row per group.
Implements getExtensionAttributes/setExtensionAttributes as required by Magento ExtensibleDataInterface contract. Enables third-party modules to attach extension attributes to LandingPage via di.xml. test: add LandingPageTest covering null default and round-trip
…ndingPage" This reverts commit a100690.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Global: my-landing-page). Store ID0is labelledGlobal.emico_attributelanding_page_store, rendered with the samestore_idprefix as the URL column.HAVING GROUP_CONCAT(...) LIKE ?clause, avoiding issues with aggregate expressions inWHERE.Page\Collection); the grid now always shows one row per landing page with all store values grouped.Model\ResourceModel\Page\Grid\Collection, a dedicated grid collection extendingSearchResult, keeping grid-specific query logic isolated from the general-purposePage\Collectionused on the frontend.How to test
Scenario 1 — Store URLs and Names are visible
Global: my-url,Default Store View: my-url).store_id = 0) row, confirm the prefix readsGlobal.Scenario 2 — One row per landing page
Scenario 3 — Searching on Store URLs
Scenario 4 — Searching on Name
Scenario 5 — Frontend is unaffected
https://magento2.test/default/women/tops-women2/).