Skip to content

Jon/fix/zec name#6004

Merged
j0ntz merged 2 commits intodevelopfrom
jon/fix/zec-name
Apr 29, 2026
Merged

Jon/fix/zec name#6004
j0ntz merged 2 commits intodevelopfrom
jon/fix/zec-name

Conversation

@j0ntz
Copy link
Copy Markdown
Contributor

@j0ntz j0ntz commented Apr 28, 2026

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

  • Yes
  • No

Dependencies

none

Requirements

If you have made any visual changes to the GUI. Make sure you have:

  • Tested on iOS device
  • Tested on Android device
  • Tested on small-screen device (iPod Touch)
  • Tested on large-screen device (tablet)

Note

Medium Risk
Touches the transaction send/save path by adding a secondary saveTxMetadata write to work around a core race, which could affect how send metadata persists across reloads. Also expands ZNS name parsing to accept multiple suffixes, potentially impacting Zcash address resolution behavior.

Overview
Improves Zcash name support by treating both .zcash and .zec as valid ZNS inputs while continuing to render resolved names with the canonical .zcash suffix.

Fixes a send-flow persistence issue where saveTx can lose tx.metadata in a race with engine transaction registration by re-applying name/notes via saveTxMetadata after broadcast, ensuring payee names and FIO notes survive disk reloads.

Updates the changelog to reflect ZNS suffix support expansion.

Reviewed by Cursor Bugbot for commit bc8261d. Bugbot is set up for automated code reviews on this repo. Configure here.


j0ntz added 2 commits April 28, 2026 16:42
There was an issue where the name shows in the scene immediately after broadcast, but gets lost when revisiting the tx in the history.
@j0ntz j0ntz merged commit dc55bf3 into develop Apr 29, 2026
4 checks passed
@j0ntz j0ntz deleted the jon/fix/zec-name branch April 29, 2026 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants