Conversation
There was an issue where the name shows in the scene immediately after broadcast, but gets lost when revisiting the tx in the history.
peachbits
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have:
Note
Medium Risk
Touches the transaction send/save path by adding a secondary
saveTxMetadatawrite to work around a core race, which could affect how send metadata persists across reloads. Also expands ZNS name parsing to accept multiple suffixes, potentially impacting Zcash address resolution behavior.Overview
Improves Zcash name support by treating both
.zcashand.zecas valid ZNS inputs while continuing to render resolved names with the canonical.zcashsuffix.Fixes a send-flow persistence issue where
saveTxcan losetx.metadatain a race with engine transaction registration by re-applyingname/notesviasaveTxMetadataafter broadcast, ensuring payee names and FIO notes survive disk reloads.Updates the changelog to reflect ZNS suffix support expansion.
Reviewed by Cursor Bugbot for commit bc8261d. Bugbot is set up for automated code reviews on this repo. Configure here.