Skip to content

ECOM-7571 Add sourceTaxRateType field to items taxes info #555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
OlegShtchLS merged 1 commit into from
May 6, 2026
Merged

ECOM-7571 Add sourceTaxRateType field to items taxes info #555

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/main/kotlin/com/ecwid/apiclient/v3/converter/FetchedOrder.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,7 @@ fun FetchedOrder.OrderItemTax.toUpdated(): UpdatedOrder.OrderItemTax {
taxOnHandlingFee = taxOnHandlingFee,
includeInPrice = includeInPrice,
taxType = taxType,
sourceTaxRateType = sourceTaxRateType,
)
}

Expand Down
1 change: 1 addition & 0 deletions src/main/kotlin/com/ecwid/apiclient/v3/dto/cart/result/CalculateOrderDetailsResult.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,7 @@ data class CalculateOrderDetailsResult(
val taxOnDiscountedSubtotal: Double? = null,
val taxOnShipping: Double? = null,
val taxOnHandlingFee: Double? = null,
val sourceTaxRateType: TaxRateType? = null,
) : BaseOrderTax

data class OrderItemProductFile(
Expand Down
8 changes: 8 additions & 0 deletions src/main/kotlin/com/ecwid/apiclient/v3/dto/order/enums/TaxRateType.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
package com.ecwid.apiclient.v3.dto.order.enums

enum class TaxRateType {
AUTO,
MANUAL,
CUSTOM,
LEGACY
}
1 change: 1 addition & 0 deletions src/main/kotlin/com/ecwid/apiclient/v3/dto/order/request/UpdatedOrder.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,6 +279,7 @@ data class UpdatedOrder(
val taxOnShipping: Double? = null,
val taxOnHandlingFee: Double? = null,
val includeInPrice: Boolean? = null,
val sourceTaxRateType: TaxRateType? = null,
val taxType: OrderItemTaxType? = null,
) : BaseOrderTax

Expand Down
11 changes: 2 additions & 9 deletions src/main/kotlin/com/ecwid/apiclient/v3/dto/order/result/FetchedOrder.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,16 +268,9 @@ data class FetchedOrder(
val taxOnHandlingFee: Double? = null,
override val includeInPrice: Boolean? = null,
val sourceTaxRateId: Int? = null,
val sourceTaxRateType: RateType? = null,
val sourceTaxRateType: TaxRateType? = null,
val taxType: OrderItemTaxType? = null,
) : ExtendedOrderTax {
enum class RateType {
AUTO,
MANUAL,
CUSTOM,
LEGACY
}
}
) : ExtendedOrderTax


data class HandlingFeeTax(
Expand Down
1 change: 1 addition & 0 deletions ...lin/com/ecwid/apiclient/v3/rule/nullablepropertyrules/CalculateOrderDetailsResultRules.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@ val calculateOrderDetailsResultNullablePropertyRules: List<NullablePropertyRule<
IgnoreNullable(CalculateOrderDetailsResult.OrderItemTax::taxOnDiscountedSubtotal),
IgnoreNullable(CalculateOrderDetailsResult.OrderItemTax::taxOnShipping),
AllowNullable(CalculateOrderDetailsResult.OrderItemTax::taxOnHandlingFee),
AllowNullable(CalculateOrderDetailsResult.OrderItemTax::sourceTaxRateType),
IgnoreNullable(CalculateOrderDetailsResult.OrderItemTax::total),
IgnoreNullable(CalculateOrderDetailsResult.OrderItemTax::value),
IgnoreNullable(CalculateOrderDetailsResult.PersonInfo::city),
Expand Down
Loading