Allow projects to be "parked"#1594
Conversation
| // Transitions to PROJ_PARKED. | ||
|
|
||
| foreach (ProjectStates::get_states() as $from_state) { | ||
| if (in_array($from_state, [PROJ_NEW, PROJ_DELETE, PROJ_PARKED, PROJ_COMPLETE, PROJ_SUBMIT_PG_POSTED])) { |
There was a problem hiding this comment.
This line dictates the project states that cannot be parked.
windymilla
left a comment
There was a problem hiding this comment.
It's a sign of the good state of the code that implementing this didn't involve many edits, and they are easily understood by someone who doesn't know the code that well. Thanks!
| string $medium_label, | ||
| string $label, | ||
| int $forum, | ||
| ?int $forum, |
There was a problem hiding this comment.
Hmm. It's mildly disturbing that PHPStan didn't catch this mismatch in all the callers. I'm guessing it couldn't properly determine that the type of SiteConfig::get()->posted_projects_forum_idx (etc) is public ?int
|
Looks great to me. |
A new "parked" state allows projects to be moved outside the usual project workflow to get fixed or worked on.
A new "parked" state allows projects to be moved outside the usual project workflow to get fixed or worked on.
Projects can be parked from the project page by a site admin. To move projects out of a parked state, the project jump page needs to be used.
Sandbox: https://www.pgdp.org/~cpeel/c.branch/proj_parked/
This PR will need to be rebased after #1592 goes in.