fix: cleanup remaining NFT stuff, get rid of stable-json-stringify#12387
Open
swkatmask wants to merge 4 commits into
Open
fix: cleanup remaining NFT stuff, get rid of stable-json-stringify#12387swkatmask wants to merge 4 commits into
swkatmask wants to merge 4 commits into
Conversation
Replace json-stable-stringify in useLineChart's effect dep array with the destructured dimension primitives (top/right/bottom/left/width/ height). The default-import interop resolved to a non-callable value in the bundled price-chart chunk, throwing on render. Dimension is a flat struct of numbers, so listing the fields directly keeps deps stable without the dependency.
Replace json-stable-stringify in useTransakURL's useMemo dep array with native JSON.stringify. The default-import interop resolved to a non-callable value in the bundled Transak chunk, throwing on render inside BuyTokenDialog so the fiat on-ramp never opened. config is a generic Partial<TransakConfig>, so JSON.stringify keeps deps stable across all fields without the dependency — same fix shape as mf-6780.
swkatmask
force-pushed
the
fix/fixup-nextid
branch
from
7c5d085 to
cb2d93d
Compare
swkatmask
force-pushed
the
fix/fixup-nextid
branch
from
cb2d93d to
0ca3488
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://mask.atlassian.net/browse/mf-6780
https://mask.atlassian.net/browse/mf-6783
https://mask.atlassian.net/browse/mf-6787