fix(dvc-pipe-proxy): handle pre-connected Windows clients#1447
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
Marc-André Moreau (mamoreau-devolutions)
July 13, 2026 12:56
View session
There was a problem hiding this comment.
Pull request overview
Improves DVC named-pipe proxy reliability, particularly for pre-connected Windows clients.
Changes:
- Handles Windows
ERROR_PIPE_CONNECTED. - Propagates thread-spawn failures and retries failed sessions.
- Adds Windows pipe-to-DVC forwarding coverage.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/platform/windows.rs |
Handles pre-connected named-pipe clients. |
src/worker.rs |
Adds startup reporting and reconnection retries. |
src/proxy.rs |
Propagates worker spawn failures. |
tests/windows_pipe.rs |
Tests Windows connection and callback forwarding. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Benoît Cortier (CBenoit)
requested a review
from Vladyslav Nikonov (vnikonov-devolutions)
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Benoît Cortier (CBenoit)
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ERROR_PIPE_CONNECTEDas a successful named-pipe acceptTests
cargo test -p ironrdp-dvc-pipe-proxy