-
Notifications
You must be signed in to change notification settings - Fork 238
feat(server)!: post-authentication connection binding for multi-user servers #1413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Piclaw (piclaw-bot)
wants to merge
16
commits into
Devolutions:master
Choose a base branch
from
rcarmo:wrdp
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
c8a0e89
Add post-auth connection binder hook
rcarmo e6a2d41
Scope reactivation credential cache to connection
rcarmo a709e6c
Expose CredSSP delegated credentials to servers
rcarmo b351505
Address post-auth binder review feedback
rcarmo 6b803e5
Avoid rebinding during RDP reactivation
rcarmo 1251143
Keep bound server handlers connection-local
8341c01
Clarify credential checks during reactivation
41ee243
Update server credential hook docs
0296cab
Avoid caching authenticated credentials
45ee78b
Document bound handler scoping
e2c884a
Track accepted credential origin
a536297
Prioritize graphics dynamic channel creation
rcarmo 88086f2
Preserve bound handlers during reactivation
ab098ac
Pair received credentials with origin
2b84e1e
Move credential handoff docs into rustdoc
2cfe112
Preserve credential validator backend errors
rcarmo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thought: The
Optionparam reads oddly at the call site (.with_connection_binder(Some(Arc::new(x)))), but it's consistent withwith_credential_validatorandwith_connection_handler. This is consistent, but I’m wondering if we should change that. Out of scope for this PR.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed; I left this unchanged for this PR to stay consistent with the adjacent optional hooks and avoid mixing API ergonomics into the correctness fixes.