Popup: Update Angular Service Code Snippets (#8870)#8872
Merged
arman-boyakhchyan merged 1 commit intoJun 12, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Angular DxPopupService documentation snippet for the Popup “Show and Hide” topic, adjusting the example to use Angular signals when passing data to dynamically created popup content components.
Changes:
- Updated the popup content component’s state handling from an
@Input()property assignment to asignal()with.set(...)updates. - Adjusted the Angular template bindings to read signal values via
currentEmployee().
vladaskorohodova
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.