upgrade to moto 5.2#683
Merged
Merged
Conversation
chris48s
commented
Jul 16, 2026
Comment on lines
-169
to
+173
| if resource["ResourceType"] == "AWS::Lambda::Function" and resource[ | ||
| "PhysicalResourceId" | ||
| ].startswith("ingest-"): | ||
| if resource.get( | ||
| "ResourceType" | ||
| ) == "AWS::Lambda::Function" and resource.get( | ||
| "PhysicalResourceId", "" | ||
| ).startswith("ingest-"): |
Member
Author
There was a problem hiding this comment.
I can't 100% explain this, but in the newer version of moto, not all dicts returned by describe_stack_resources() has all of these keys. I've just used .get() on both ResourceType and PhysicalResourceId so the incomplete entries are skipped.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #683 +/- ##
=======================================
Coverage 93.06% 93.06%
=======================================
Files 3 3
Lines 101 101
=======================================
Hits 94 94
Misses 7 7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
awdem
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs https://app.asana.com/1/1204880536137786/project/1215330308772861/task/1214889415488586?focus=true