fix(ui): add missing "solid" keyword to disclaimer border in new UI#15001
Open
ksitton58 wants to merge 1 commit into
Open
fix(ui): add missing "solid" keyword to disclaimer border in new UI#15001ksitton58 wants to merge 1 commit into
ksitton58 wants to merge 1 commit into
Conversation
The disclaimer warning box set its border as border:1px DefectDojo#3333 -- a shorthand with width and color but no style keyword. Per the CSS spec, border-style defaults to "none", so the border never renders. Adding "solid" makes the intended border visible. This is engine-agnostic (applies to both the on-screen views and the report/PDF output). Fixed across the new UI (dojo/templates/): - Interactive views: view_test.html, form_fields.html, findings_list_snippet.html - Report templates: custom_html_report.html and the *_pdf_report.html set (endpoint, engagement, finding, product, product_endpoint, product_type, test) Out of scope here (same bug, deliberately separate): - Classic UI (dojo/templates_classic/) -- being deprecated. - Email notification templates (.tpl) -- different rendering engine.
ksitton58
force-pushed
the
fix/new-ui-disclaimer-border-style
branch
from
97d70f3 to
614a10b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes an invisible border on the disclaimer warning box throughout the new (Tailwind) UI.
The disclaimer box set its border with
border:1px #003333— width and color, but noborder-style keyword. Per the CSS spec,
border-styledefaults tonone, so the bordernever renders regardless of width/color. The box was clearly meant to have a border (it
sets both), but none displayed. Adding
solidmakes it render — this applies equally tothe on-screen views and the report/PDF output.
Fixed across
dojo/templates/:view_test.html,form_fields.html,findings_list_snippet.htmlcustom_html_report.htmland the*_pdf_report.htmlset (endpoint,engagement, finding, product, product_endpoint, product_type, test)
Out of scope (same bug, deliberately separate): the classic UI (
dojo/templates_classic/,being deprecated) and the email notification
.tpltemplates (different rendering engine).Test results
One-property CSS correction, no logic change. Confirmed the shorthand was the cause:
border:1px <color>computesborder-style:none/border-width:0(no border); addingsolidrenders a 1px border. Verified the computed values in-browser. No Python changed,so no unit tests added.
Documentation
N/A.
Checklist
bugfixbranch.