Fix node column resolution for role playing dimensions#2331
Merged
Conversation
✅ Deploy Preview for thriving-cassata-78ae72 canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix role-playing dimension column resolution in column-scoped endpoints
Problem
get_node_column — the shared resolver behind the set-partition, remove-partition, and set-attributes endpoints — resolves columns strictly by bare name, with no awareness of the role suffix (dimension_column). For a node with two columns sharing a bare name but different roles (e.g. a date dim reached via two FKs), this caused two bugs:
Surfaced on cube arc.content_migration.cade_batch_funnel, where a UI materialize intending [epoch_date] silently landed the partition on [region_date].
Fix
Resolve by the role-qualified identity (name + dimension_column) first, fall back to bare name only when unambiguous, and raise a 422 listing the role-qualified options when a bare name is ambiguous — instead of silently picking one. Fixing the shared resolver fixes set-partition, remove-partition, and set-attributes at once. No endpoint signature or client changes.
Tests