Skip to content

Add coverage for DBM dynamic_service mode#6997

Open
amarziali wants to merge 4 commits into
mainfrom
andrea.marziali/dbm2
Open

Add coverage for DBM dynamic_service mode#6997
amarziali wants to merge 4 commits into
mainfrom
andrea.marziali/dbm2

Conversation

@amarziali
Copy link
Copy Markdown
Contributor

Motivation

Add coverage for the new DD_DBM_PROPAGATION_MODE=dynamic_service value that combines service mode behaviour with automatic SQL base hash injection, without requiring users to separately set DD_DBM_INJECT_SQL_BASEHASH=true.

Setting dynamic_service is equivalent to:

DD_DBM_PROPAGATION_MODE=service
DD_DBM_INJECT_SQL_BASEHASH=true

The test checks that the basehash is the same in both the ddsh comment field and the related span meta _dd. propagated_hash

Note: already tested working locally with the in progress java implementation: DataDog/dd-trace-java#11432

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

@amarziali amarziali requested review from a team as code owners May 21, 2026 10:11
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 21, 2026

CODEOWNERS have been resolved as:

.github/workflows/run-end-to-end.yml                                    @DataDog/system-tests-core
manifests/cpp.yml                                                       @DataDog/dd-trace-cpp
manifests/cpp_nginx.yml                                                 @DataDog/dd-trace-cpp
manifests/dotnet.yml                                                    @DataDog/apm-dotnet @DataDog/asm-dotnet
manifests/golang.yml                                                    @DataDog/dd-trace-go-guild
manifests/java.yml                                                      @DataDog/asm-java @DataDog/apm-java
manifests/java_otel.yml                                                 @DataDog/system-tests-core
manifests/nodejs.yml                                                    @DataDog/dd-trace-js
manifests/nodejs_otel.yml                                               @DataDog/system-tests-core
manifests/php.yml                                                       @DataDog/apm-php @DataDog/asm-php
manifests/python.yml                                                    @DataDog/apm-python @DataDog/asm-python
manifests/python_otel.yml                                               @DataDog/apm-python @DataDog/asm-python
manifests/ruby.yml                                                      @DataDog/ruby-guild @DataDog/asm-ruby
manifests/rust.yml                                                      @DataDog/apm-rust
tests/integrations/test_dbm.py                                          @DataDog/system-tests-core
utils/_context/_scenarios/__init__.py                                   @DataDog/system-tests-core
utils/_context/_scenarios/integrations.py                               @DataDog/system-tests-core
utils/_features.py                                                      @DataDog/system-tests-core

@datadog-official
Copy link
Copy Markdown

datadog-official Bot commented May 21, 2026

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: f213d25 | Docs | Datadog PR Page | Give us feedback!

Comment thread utils/_context/_scenarios/__init__.py
@amarziali amarziali force-pushed the andrea.marziali/dbm2 branch from f257776 to 68153e0 Compare May 22, 2026 07:58
@amarziali amarziali requested a review from cbeauchesne May 22, 2026 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants