Specify node-gyp-build to major v4#336
Merged
Merged
Conversation
Overall package sizeSelf size: 2.09 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | source-map | 0.7.6 | 185.63 kB | 185.63 kB | | pprof-format | 2.2.1 | 163.06 kB | 163.06 kB | | node-gyp-build | 4.8.4 | 13.86 kB | 13.86 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
This comment has been minimized.
This comment has been minimized.
IlyasShabi
force-pushed
the
ishabi/downgrade-node-gyp-build
branch
from
5326290 to
a40313b
Compare
IlyasShabi
changed the title
szegedi
approved these changes
May 21, 2026
Merged
IlyasShabi
added a commit
that referenced
this pull request
May 21, 2026
* Fix release tag push and pin actions by SHA (#335) The release workflow's tag push was rejected by the tag ruleset because actions/checkout persisted GITHUB_TOKEN credentials, which took precedence over the dd-octo-sts token in the explicit push URL. Drop the persisted credentials and downgrade contents permission to read. Also pin actions/download-artifact and actions/setup-node by commit SHA. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * Specify node-gyp-build to major v4 (#336) * build(deps-dev): bump @types/node from 25.7.0 to 25.9.1 (#333) Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 25.7.0 to 25.9.1. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) --- updated-dependencies: - dependency-name: "@types/node" dependency-version: 25.9.1 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Attila Szegedi <szegedi@users.noreply.github.com> * v5.14.4 --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Christoph Hamsen <37963496+xopham@users.noreply.github.com> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Attila Szegedi <szegedi@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
Specify node-gyp-build to major v4
Motivation:
The new release have different prebuilds caused by node-gyp-build v4 https://www.npmjs.com/package/@datadog/pprof/v/5.14.3?activeTab=code
Additional Notes:
In order to bump node-gyp-build we should do it one shot in datadog addons and action-prebuildify too.
How to test the change?: