-
Notifications
You must be signed in to change notification settings - Fork 12
WIP: Allow passing command line properties to tests #577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
5f5fa35
Don't preload jmethodIDs when cstack=vm with hotspot JVM
zhengyu123 4e3bf98
v1
zhengyu123 957d27c
v2
zhengyu123 14728a7
v3
zhengyu123 64e183b
Clean up
zhengyu123 c782c3c
Fix
zhengyu123 c462d85
Add application/platform class loader support
zhengyu123 7710c6f
Fix
zhengyu123 6c6f1a7
Fix
zhengyu123 07c3a4c
Harden symbolAt()
zhengyu123 4827c68
Merge branch 'main' into hs_jmethod_id
zhengyu123 3dda4e3
force_jmethodID argument
zhengyu123 a826e7e
Consolidate JVM initialization
zhengyu123 9d1818a
Cleanup: fixed typo and etc.
zhengyu123 13349c3
Remove dead code
zhengyu123 06b1a92
Fix
zhengyu123 b95c88c
Fix
zhengyu123 df5e992
Fix
zhengyu123 c26aeea
Handle hidden classes
zhengyu123 b2a9a1d
Review comments
zhengyu123 b56c6b4
Clean up
zhengyu123 7567904
Review comments
zhengyu123 79adaea
Correct comment
zhengyu123 b67b5cc
Create testProcess{Config} task that can pass command line profiler.o…
zhengyu123 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| /* | ||
| * Copyright The async-profiler authors | ||
| * Copyright 2026, Datadog, Inc. | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| */ | ||
|
|
||
| #include "flightRecorder.h" | ||
|
|
||
| #include "jvmSupport.inline.h" | ||
|
|
||
|
|
||
| jint MethodInfo::getLineNumber(jint bci) { | ||
| // if the shared pointer is not pointing to the line number table, consider | ||
| // size 0 | ||
| if (!_line_number_table || _line_number_table->_size == 0) { | ||
| return 0; | ||
| } | ||
|
|
||
| int i = 1; | ||
| while (i < _line_number_table->_size && | ||
| bci >= ((jvmtiLineNumberEntry *)_line_number_table->_ptr)[i] | ||
| .start_location) { | ||
| i++; | ||
| } | ||
| return ((jvmtiLineNumberEntry *)_line_number_table->_ptr)[i - 1] | ||
| .line_number; | ||
| } | ||
|
|
||
| bool MethodInfo::isHidden() { | ||
| return JVMSupport::isHidden(_modifiers); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This only wires
-Pprofiler.optionsinto the Exec-based paths, but on glibc/macOS the regulartest<Config>tasks are created bycreateTestTask, which never adds-Dddprof.test.optionsto its JVM args. As a result, the documented/normal workflow such astestDebug -Pprofiler.options=...silently ignores the override unless the user switches to the newtestProcess<Config>task or runs on musl.Useful? React with 👍 / 👎.